-
Notifications
You must be signed in to change notification settings - Fork 4.5k
test: removed toggleBar command and replaced with ts helper #33835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
cab645a
b62916c
d184cfe
a8d4f5d
beb1418
04e2bdf
8699ffc
ca742da
43d9643
175a1ef
d9a6660
1ab2f24
65d46d5
e5ecb7a
0db1d0a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,7 @@ describe( | |
| /** | ||
| * @param{toggleButton Css} Assert to be checked | ||
| */ | ||
| cy.togglebar(widgetsPage.defaultcheck); | ||
| _.agHelper.CheckUncheck(widgetsPage.defaultcheck); | ||
| /** | ||
| * @param{Show Alert} Css for InputChange | ||
| */ | ||
|
|
@@ -45,7 +45,7 @@ describe( | |
| }); | ||
| it("Checkbox Functionality To Check Disabled Widget", function () { | ||
| cy.openPropertyPane("checkboxwidget"); | ||
| cy.togglebar(commonlocators.Disablejs + " " + "input"); | ||
| _.agHelper.CheckUncheck(commonlocators.Disablejs + " " + "input"); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider using template literals for better readability and consistency. - cy.get(publish.checkboxWidget + " " + "input").should("be.disabled");
+ cy.get(`${publish.checkboxWidget} input`).should("be.disabled");
|
||
| _.deployMode.DeployApp(); | ||
| cy.get(publish.checkboxWidget + " " + "input").should("be.disabled"); | ||
| }); | ||
|
|
@@ -63,7 +63,7 @@ describe( | |
| }); | ||
| it("Checkbox Functionality To Check Visible Widget", function () { | ||
| cy.openPropertyPane("checkboxwidget"); | ||
| cy.togglebar(commonlocators.visibleCheckbox); | ||
| _.agHelper.CheckUncheck(commonlocators.visibleCheckbox); | ||
| _.deployMode.DeployApp(); | ||
| cy.get(publish.checkboxWidget + " " + "input").should("be.checked"); | ||
| }); | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -65,7 +65,7 @@ describe( | |||||
| deployMode.NavigateBacktoEditor(); | ||||||
| //Image Widget Functionality To Check Visible Widget", function () { | ||||||
| cy.openPropertyPane("imagewidget"); | ||||||
| cy.togglebar(commonlocators.visibleCheckbox); | ||||||
| agHelper.CheckUncheck(commonlocators.visibleCheckbox); | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replace function expression with an arrow function for consistency. - it("3. Image Widget Functionality To Check/Uncheck Visible Widget", function () {
+ it("3. Image Widget Functionality To Check/Uncheck Visible Widget", () => {Committable suggestion
Suggested change
|
||||||
| deployMode.DeployApp(publish.imageWidget); | ||||||
| deployMode.NavigateBacktoEditor(); | ||||||
| }); | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace function expression with an arrow function for consistency.