Skip to content

chore: Checkbox widget does not show an asterisk to indicate it's a required #33814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KelvinOm merged 3 commits into from
May 30, 2024
Merged

chore: Checkbox widget does not show an asterisk to indicate it's a required #33814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86b1251
add asterik for checkbox
May 29, 2024
72efa3d
remove isRequired prop from readonly story
May 29, 2024
895c87c
remove isRequired prop from readonly story
May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...es/design-system/widgets/src/components/Checkbox/chromatic/Checkbox.chromatic.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,12 @@ export const LightMode: Story = {
</DataAttrWrapper>
</>
))}
<Checkbox defaultSelected isReadOnly isRequired>
<Checkbox defaultSelected isReadOnly>
Readonly
</Checkbox>
<Checkbox defaultSelected isRequired>
Is Required
</Checkbox>
</StoryGrid>
),
};
Expand Down
14 changes: 13 additions & 1 deletion app/client/packages/design-system/widgets/src/components/Checkbox/src/Checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,19 @@ const _Checkbox = (props: CheckboxProps, ref: HeadlessCheckboxRef) => {
inlineLabelStyles["inline-label"],
)}
>
{Boolean(children) && <Text>{children}</Text>}
{Boolean(children) && (
<>
<Text>{children}</Text>
{Boolean(props.isRequired) && (
<Text
color="negative"
data-inline-label-necessity-indicator-icon=""
>
*
</Text>
)}
</>
)}
</HeadlessCheckbox>
);
};
Expand Down
13 changes: 9 additions & 4 deletions app/client/packages/design-system/widgets/src/components/Checkbox/src/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@
--checkbox-border-color: var(--color-bd-neutral-hover);
}

& [data-inline-label-necessity-indicator-icon] {
color: var(--color-fg-negative);
margin-inline-start: var(--inner-spacing-1);
}

/**
* ----------------------------------------------------------------------------
* LABEL POSITION
Expand Down Expand Up @@ -86,10 +91,10 @@
}

/**
* ----------------------------------------------------------------------------
* ERROR ( INVALID )
*-----------------------------------------------------------------------------
*/
* ----------------------------------------------------------------------------
* ERROR ( INVALID )
*-----------------------------------------------------------------------------
*/
&[data-invalid] [data-icon] {
--checkbox-border-color: var(--color-bd-negative);
}
Expand Down
8 changes: 8 additions & 0 deletions ...lient/packages/design-system/widgets/src/components/Checkbox/stories/Checkbox.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,11 @@ export const CustomIcon: Story = {
</Flex>
),
};

export const IsRequired: Story = {
render: () => (
<Flex direction="column" gap="1rem" wrap="wrap">
<Checkbox isRequired>Required</Checkbox>
</Flex>
),
};
2 changes: 1 addition & 1 deletion app/client/packages/design-system/widgets/src/styles/src/field.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
*/
& [data-field-necessity-indicator-icon] {
color: var(--color-fg-negative);
margin-left: var(--inner-spacing-1);
margin-inline-start: var(--inner-spacing-1);
Copy link
Contributor Author

@jsartisan jsartisan May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny refactor.

}

/**
Expand Down