Skip to content

chore: WDS inputs in dark mode with better visibility#33796

Merged
KelvinOm merged 1 commit intoreleasefrom
chore/wds-color-darkmode-inputs
May 28, 2024
Merged

chore: WDS inputs in dark mode with better visibility#33796
KelvinOm merged 1 commit intoreleasefrom
chore/wds-color-darkmode-inputs

Conversation

@ichik
Copy link
Contributor

@ichik ichik commented May 28, 2024

Description

Fixes #33623

Before After
Screenshot 2024-05-28 at 12-10-22 Untitled application 1 Editor Appsmith Screenshot 2024-05-28 at 12-12-08 Untitled application 1 Editor Appsmith

Automation

/ok-to-test tags="@tag.Anvil"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9267589083
Commit: 57a332a
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@ichik ichik added the ok-to-test Required label for CI label May 28, 2024
@ichik ichik requested a review from KelvinOm May 28, 2024 10:18
@ichik ichik self-assigned this May 28, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 28, 2024

Walkthrough

Walkthrough

The recent updates to the DarkModeTheme.ts file involve adjustments to the conditions for modifying color properties based on seed values. Specifically, the threshold values for lightness and chroma adjustments have been changed. Correspondingly, test cases in DarkModeTheme.test.ts were updated to reflect the new expected RGB color values.

Changes

File Path Change Summary
app/client/packages/design-system/theming/src/color/src/DarkModeTheme.ts Adjusted conditions for modifying color.oklch.l and color.oklch.c based on new threshold values (0.29 and 0.025 respectively).
app/client/packages/design-system/theming/src/color/tests/DarkModeTheme.test.ts Updated expected RGB color values in test cases for bgNeutralSubtle, bgNeutralSubtleHover, and bgNeutralSubtleActive colors to match new logic.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between ba23317 and 57a332a.
Files selected for processing (2)
  • app/client/packages/design-system/theming/src/color/src/DarkModeTheme.ts (1 hunks)
  • app/client/packages/design-system/theming/src/color/tests/DarkModeTheme.test.ts (4 hunks)
Files not reviewed due to errors (1)
  • app/client/packages/design-system/theming/src/color/src/DarkModeTheme.ts (no review received)
Files skipped from review due to trivial changes (1)
  • app/client/packages/design-system/theming/src/color/tests/DarkModeTheme.test.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Anvil Pod Issue related to Anvil project Task A simple Todo WDS team skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels May 28, 2024
@KelvinOm KelvinOm merged commit 96c340e into release May 28, 2024
@KelvinOm KelvinOm deleted the chore/wds-color-darkmode-inputs branch May 28, 2024 10:58
@coderabbitai coderabbitai bot mentioned this pull request Apr 2, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Anvil Pod Issue related to Anvil project ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo WDS team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make inputs in dark mode bit brighter

2 participants