Revert "feat: Collapsible Bottom View"

[trishaanand]

Reverts #33441

[coderabbitai]

Walkthrough

Walkthrough

The recent changes primarily focus on enhancing the debugger functionality and UI consistency within the application. Key updates include the introduction of new constants, styled components, and refactoring of existing components to improve layout calculations and state management. Additionally, several files have been reformatted for better readability and maintainability.

Changes

Files	Change Summary
app/client/cypress/support/Pages/DebuggerHelper.ts	Added bottomPaneHeight and TAB_MIN_HEIGHT constants to the DebuggerHelper class.
app/client/src/IDE/index.ts	Reformatted comments for better clarity and consistency.
app/client/src/components/editorComponents/ApiResponseView.tsx	Refactored to use useRef instead of useState, introduced new styled components, updated debugger state management, and refactored return structure.
app/client/src/components/editorComponents/Debugger/DebuggerTabs.tsx	Added new imports, introduced CloseDebugger and Container styled components, updated component structure.
app/client/src/components/editorComponents/Debugger/Resizer/index.tsx	Removed minHeight property from ResizerProps interface, introduced local minHeight variable.
app/client/src/components/editorComponents/EntityBottomTabs.tsx	Removed isCollapsed prop from EntityBottomTabsProps, updated logic to always render tabs.
app/client/src/components/editorComponents/JSResponseView.tsx	Added new imports and styled components, refactored component structure and debugger state management logic.
app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx	Updated Wrapper styled component to use calc(100% - 135px) for height calculation.
app/client/src/pages/Editor/DataSourceEditor/DBForm.tsx	Adjusted height calculation based on viewMode and theme.backBanner.
app/client/src/pages/Editor/DataSourceEditor/Debugger.tsx	Added new imports, introduced TabbedViewContainer and ResizerMainContainer styled components, updated return structure, and added CloseDebugger component.
app/client/src/pages/Editor/JSEditor/Form.tsx	Updated Wrapper styled component to use calc(100% - 64px) for height calculation.
app/client/src/pages/Editor/JSEditor/styledComponents.ts	Updated FormWrapper and Form styled components to include ${theme.backBanner} in height calculations.
app/client/src/pages/Editor/QueryEditor/QueryDebuggerTabs.tsx	Added new imports, introduced TabbedViewContainer styled component, updated debugger visibility and tab selection logic, reorganized structure for displaying debugger tabs and results.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 039f664 and 24381dd.

Files selected for processing (13)

• app/client/cypress/support/Pages/DebuggerHelper.ts (1 hunks)
• app/client/src/IDE/index.ts (3 hunks)
• app/client/src/components/editorComponents/ApiResponseView.tsx (7 hunks)
• app/client/src/components/editorComponents/Debugger/DebuggerTabs.tsx (3 hunks)
• app/client/src/components/editorComponents/Debugger/Resizer/index.tsx (2 hunks)
• app/client/src/components/editorComponents/EntityBottomTabs.tsx (2 hunks)
• app/client/src/components/editorComponents/JSResponseView.tsx (7 hunks)
• app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx (1 hunks)
• app/client/src/pages/Editor/DataSourceEditor/DBForm.tsx (1 hunks)
• app/client/src/pages/Editor/DataSourceEditor/Debugger.tsx (4 hunks)
• app/client/src/pages/Editor/JSEditor/Form.tsx (1 hunks)
• app/client/src/pages/Editor/JSEditor/styledComponents.ts (2 hunks)
• app/client/src/pages/Editor/QueryEditor/QueryDebuggerTabs.tsx (7 hunks)

Files skipped from review due to trivial changes (3)

• app/client/src/IDE/index.ts
• app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx
• app/client/src/pages/Editor/JSEditor/Form.tsx

Additional comments not posted (10)

app/client/src/components/editorComponents/EntityBottomTabs.tsx (1)

67-67: Ensure the selectedTabKey prop is always valid to prevent UI errors.

app/client/src/pages/Editor/JSEditor/styledComponents.ts (1)

34-35: Verify that the theme variables used (smallHeaderHeight, backBanner) provide the expected results in different themes.

Also applies to: 46-46

app/client/src/components/editorComponents/Debugger/Resizer/index.tsx (1)

55-57: Consider adding error handling for cases where minHeight might not be set or could be an unexpected value.

Also applies to: 61-61

app/client/src/components/editorComponents/Debugger/DebuggerTabs.tsx (1)

35-42: Verify that the ActionExecutionResizerHeight provides a user-friendly experience and consider adjusting it based on user feedback.

Also applies to: 110-137

app/client/src/pages/Editor/DataSourceEditor/DBForm.tsx (1)

44-45: Consider adding comments to clarify why the height adjustment is necessary in non-view modes.

app/client/src/pages/Editor/DataSourceEditor/Debugger.tsx (1)

157-186: Test the resizing functionality extensively to ensure it works smoothly across different devices and resolutions.

app/client/cypress/support/Pages/DebuggerHelper.ts (1)

16-18: Constants bottomPaneHeight and TAB_MIN_HEIGHT added for managing pane dimensions.

app/client/src/pages/Editor/QueryEditor/QueryDebuggerTabs.tsx (1)

1-12: Import and usage of useRef, useDispatch, and useSelector hooks.

app/client/src/components/editorComponents/JSResponseView.tsx (1)

1-8: Import and usage of multiple React hooks and styled components.

app/client/src/components/editorComponents/ApiResponseView.tsx (1)

1-2: Import and usage of useRef, useCallback, and useState hooks.

Verification successful

---

The ApiResponseView component is properly integrated and used across multiple files in the codebase. Here are the relevant locations:

• app/client/src/pages/Editor/QueryEditor/QueryResponseTab.tsx
• app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx
• app/client/src/components/editorComponents/JSResponseView.tsx
• app/client/src/components/editorComponents/ApiResponseView.test.tsx

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify integration of `ApiResponseView` with the rest of the application.

# Test: Search for the component usage. Expect: Proper integration in relevant files.
rg --type typescript $'ApiResponseView'

Length of output: 73

---

---

Script:

#!/bin/bash
# Description: Verify integration of `ApiResponseView` with the rest of the application.

# Test: Search for the component usage. Expect: Proper integration in relevant files.
rg --type ts,tsx 'ApiResponseView'

Length of output: 65

---

---

Script:

#!/bin/bash
# Description: Verify integration of `ApiResponseView` with the rest of the application.

# Test: Search for the component usage. Expect: Proper integration in relevant files.
rg --type-add 'ts:*.{ts,tsx}' 'ApiResponseView'

Length of output: 1195

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.