chore: Remove explicit JSON props

[sharat87]

The explicitly set JSON property names are making Hibernate unhappy (didn't look into full details, but removing them was good). And since this is neither needed here (since the field names are the same), nor are we doing this anywhere else in our code (breaking consistency), and isn't adding any additional value either, we're removing it.

/test all

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9347505983
Commit: 45911b0
Cypress dashboard url: Click here!

[coderabbitai]

Walkthrough

Walkthrough

The recent changes simplify the CustomJSLib and CustomJSLibCE classes by removing @JsonCreator and @JsonProperty annotations from their constructors. Instead, new setter methods have been introduced to handle value assignments and related computations, such as setAccessor, setUrl, and recomputeUid. This refactoring aims to streamline the code and improve maintainability.

Changes

File Path	Change Summary
app/server/appsmith-server/src/main/java/com/appsmith/server/domains/CustomJSLib.java	Simplified constructor by removing @JsonCreator and @JsonProperty annotations.
app/server/appsmith-server/src/main/java/com/appsmith/server/domains/ce/CustomJSLibCE.java	Refactored constructor and added setter methods (setAccessor, setUrl) and a private method recomputeUid. Removed @JsonCreator and @JsonProperty annotations. Added import for CollectionUtils.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant Client
    participant Server
    participant CustomJSLib
    participant CustomJSLibCE

    Client->>Server: Request to create CustomJSLib
    Server->>CustomJSLib: Instantiate CustomJSLib with parameters
    CustomJSLib-->>Server: Return CustomJSLib object

    Client->>Server: Request to create CustomJSLibCE
    Server->>CustomJSLibCE: Instantiate CustomJSLibCE with parameters
    CustomJSLibCE->>CustomJSLibCE: setAccessor()
    CustomJSLibCE->>CustomJSLibCE: setUrl()
    CustomJSLibCE->>CustomJSLibCE: recomputeUid()
    CustomJSLibCE-->>Server: Return CustomJSLibCE object

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4b50a7f and 45911b0.

Files selected for processing (2)

• app/server/appsmith-server/src/main/java/com/appsmith/server/domains/CustomJSLib.java (2 hunks)
• app/server/appsmith-server/src/main/java/com/appsmith/server/domains/ce/CustomJSLibCE.java (2 hunks)

Files skipped from review due to trivial changes (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/domains/CustomJSLib.java

Additional comments not posted (3)

app/server/appsmith-server/src/main/java/com/appsmith/server/domains/ce/CustomJSLibCE.java (3)

60-66: Constructor refactoring looks good, ensuring encapsulation by using setters.

---

69-72: Proper encapsulation in setAccessor by recomputing UID after setting the value.

---

74-77: Consistent handling in setUrl with UID recomputation, aligning with other setters.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1