Skip to content

chore: remove cypress hardcoded strings and waits #33513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushpahwa merged 3 commits into from
May 16, 2024
Merged

chore: remove cypress hardcoded strings and waits #33513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb49a55
update: added string constants
ayushpahwa May 16, 2024
affbceb
update: removed static wait
ayushpahwa May 16, 2024
9afff27
refactor: prettier
ayushpahwa May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,10 @@ describe("Git sync:", { tags: ["@tag.Git"] }, function () {
false,
EntityItems.Page,
);
agHelper.RemoveUIElement("Tooltip", "Add a new query/JS Object");
agHelper.RemoveUIElement(
"Tooltip",
Cypress.env("MESSAGES").ADD_QUERY_JS_TOOLTIP(),
);
PageLeftPane.switchSegment(PagePaneSegment.Queries);
entityExplorer.RenameEntityFromExplorer("ParentApi1", "ParentApiRenamed");

Expand Down
5 changes: 4 additions & 1 deletion app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/Replay_Editor_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ describe("Undo/Redo functionality", function () {
"https://mock-api.appsmith.com/users", //testing placeholder!
);
cy.enterDatasourceAndPath(testdata.baseUrl, testdata.methods);
agHelper.RemoveUIElement("Tooltip", "Add a new query/JS Object");
agHelper.RemoveUIElement(
"Tooltip",
Cypress.env("MESSAGES").ADD_QUERY_JS_TOOLTIP(),
);
cy.get(`${apiwidget.headerKey}`).type("Authorization");
cy.get("body").click(0, 0);
cy.get(apiwidget.settings).click({ force: true });
Expand Down
7 changes: 5 additions & 2 deletions app/client/cypress/support/Pages/ApiPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,10 @@ export class ApiPage {
PageLeftPane.switchSegment(PagePaneSegment.Queries);
this.agHelper.GetHoverNClick(this.locator._createNew);
this.agHelper.GetNClick(this._blankAPI, 0, true);
this.agHelper.RemoveUIElement("Tooltip", "Add a new query/JS Object");
this.agHelper.RemoveUIElement(
"Tooltip",
Cypress.env("MESSAGES").ADD_QUERY_JS_TOOLTIP(),
);
}
this.assertHelper.AssertNetworkStatus("@createNewApi", 201);

Expand Down Expand Up @@ -138,7 +141,7 @@ export class ApiPage {
) {
this.CreateApi(apiName, apiVerb, aftDSSaved);
this.EnterURL(url, "", toVerifySave);
this.agHelper.Sleep(); //Is needed for the entered url value to be registered, else failing locally & CI
this.assertHelper.AssertNetworkStatus("@saveAction", 200);
this.AssertRunButtonDisability();
if (queryTimeout != 10000) this.SetAPITimeout(queryTimeout, toVerifySave);
}
Expand Down
5 changes: 4 additions & 1 deletion app/client/cypress/support/Pages/JSEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,10 @@ export class JSEditor {
PageLeftPane.switchSegment(PagePaneSegment.JS);
cy.get(this._newJSobj).eq(0).click({ force: true });

this.agHelper.RemoveUIElement("Tooltip", "Add a new query/JS Object");
this.agHelper.RemoveUIElement(
"Tooltip",
Cypress.env("MESSAGES").ADD_QUERY_JS_TOOLTIP(),
);
//Checking JS object was created successfully
this.assertHelper.AssertNetworkStatus("@jsCollections", 200);
this.agHelper.AssertElementVisibility(this._jsObjTxt);
Expand Down