Skip to content

fix: allowing bottom tabs to be selectable as text #33263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmanAgarwal041 merged 16 commits into from
May 13, 2024
Merged

fix: allowing bottom tabs to be selectable as text #33263

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a49c9ef
fix: allowing bottom tabs to be selectable as text
May 8, 2024
a6fb06e
fix: allowing bottom tabs to be selectable as text
May 8, 2024
7199042
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/32…
May 9, 2024
cbe5907
fix: added tag debugger in tags.js
May 9, 2024
fbc599a
fix: jest test cases for debugger views
May 9, 2024
369190a
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/32…
May 9, 2024
6143bd8
fix: jest test cases
May 10, 2024
091adb5
fix: jest test cases
May 10, 2024
5b21f68
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/32…
May 10, 2024
d41a9c3
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/32…
May 10, 2024
98313f2
fix: jest test cases
May 10, 2024
7092a21
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/32…
May 10, 2024
aae482b
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/32…
May 11, 2024
76a06a0
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/32…
May 13, 2024
1403786
fix: removed debugger tag from tags.json
May 13, 2024
9aeb5f4
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/32…
May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/client/cypress/tags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,6 @@ module.exports = {
"@tag.Visual",
"@tag.Module",
"@tag.Workflows",
"@tag.Debugger",
Comment thread
AmanAgarwal041 marked this conversation as resolved.
Outdated
],
};
5 changes: 4 additions & 1 deletion app/client/src/components/editorComponents/ApiResponseView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,10 @@ function ApiResponseView(props: Props) {
if (!open) return null;

return (
<ResponseContainer className="t--api-bottom-pane-container" ref={panelRef}>
<ResponseContainer
className="t--api-bottom-pane-container select-text"
ref={panelRef}
>
<Resizer
initialHeight={responseTabHeight}
onResizeComplete={(height: number) => {
Expand Down
2 changes: 1 addition & 1 deletion app/client/src/components/editorComponents/JSResponseView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ function JSResponseView(props: Props) {
// Do not render if header tab is selected in the bottom bar.
return open && selectedTab ? (
<ResponseContainer
className="t--js-editor-bottom-pane-container"
className="t--js-editor-bottom-pane-container select-text"
ref={panelRef}
>
<Resizer
Expand Down
2 changes: 1 addition & 1 deletion app/client/src/pages/Editor/DataSourceEditor/Debugger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ export default function Debugger() {

return shouldRender ? (
<TabbedViewContainer
className="t--datasource-bottom-pane-container"
className="t--datasource-bottom-pane-container select-text"
ref={panelRef}
>
<Resizable
Expand Down
2 changes: 1 addition & 1 deletion app/client/src/pages/Editor/QueryEditor/QueryDebuggerTabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ function QueryDebuggerTabs({

return (
<TabbedViewContainer
className="t--query-bottom-pane-container"
className="t--query-bottom-pane-container select-text"
ref={panelRef}
>
<Resizable
Expand Down