fix: cypress flakiness due to focus cypress function #33106
Conversation
WalkthroughThe changes across the files aim to enhance the reliability of UI interactions and optimize test performance in the Cypress test suite. By adding click actions before typing and streamlining wait times, the modifications improve the accuracy and efficiency of the tests. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/UpdateApplication_spec.js
Show resolved
Hide resolved
|
/ci-test-limit |
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
app/client/cypress/limited-tests.txt (1)
Line range hint
9-9: Consider adding the article "the" for grammatical correctness.-#ci-test-limit uses this file to run minimum of specs. Do not run entire suite with this command. +#ci-test-limit uses this file to run the minimum of specs. Do not run the entire suite with this command.
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8909517866. |
|
/ci-test-limit |
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
app/client/cypress/limited-tests.txt (1)
Line range hint
13-13: Consider rephrasing for clarity and grammatical correctness.-#ci-test-limit uses this file to run minimum of specs. Do not run entire suite with this command. +#ci-test-limit uses this file to run a minimum number of specs. Do not run the entire suite with this command.
app/client/cypress/limited-tests.txt
Outdated
| @@ -1,5 +1,11 @@ | |||
| # To run only limited tests - give the spec names in below format: | |||
There was a problem hiding this comment.
Consider adding the article "the" for grammatical correctness.
-# To run only limited tests - give the spec names in below format:
+# To run only limited tests - give the spec names in the below format:Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| # To run only limited tests - give the spec names in below format: | |
| # To run only limited tests - give the spec names in the below format: |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8911414904. |
AmanAgarwal041
added
ok-to-test
Description
Updating the
focuscypress function toclickfunction to avoid flakiness.Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8912061233
Commit: a154102
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?