test: Cypress | Flaky fixes #31270

Aishwarya-U-R · 2024-02-26T06:23:30Z

Description

This PR fixes flakyness in below specs:
cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js
By improving homePage.OpenWorkspaceOptions() & homePage.RenameWorkspace() methods

Type of change

Script fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Cypress CI runs

Checklist:

QA activity:

Added Test Plan Approved label after CI runs were successful & changes reviewed

Summary by CodeRabbit

Tests
- Expanded coverage of limited tests with new spec files and temporarily disabled one existing spec.
New Features
- Enhanced the workspace renaming feature in the HomePage with additional checks for element visibility and network status.
Refactor
- Updated the TypeAndClearTextField method in AggregateHelper to return results, improving testability and feedback.

coderabbitai · 2024-02-26T06:23:37Z

Walkthrough

This update primarily enhances the test suite and improves user interaction handling in the application's home page. By adding new test specifications and adjusting existing ones, the coverage of limited tests is expanded. Simultaneously, updates to the HomePage class introduce more robust handling of workspace options, including visibility checks and input manipulations. The AggregateHelper class sees a modification in its method to return a result, enhancing the functionality or feedback from text field interactions.

Changes

Files	Summary
`app/client/cypress/.../limited-tests.txt`	Added new test spec files and commented out an existing spec for expanded limited test coverage.
`app/client/cypress/.../HomePage.ts`	Updated `OpenWorkspaceOptions` with additional assertions and a new variable for workspace renaming.
`app/client/cypress/.../AggregateHelper.ts`	Changed `TypeAndClearTextField` to return `TypeText` result.

Related issues

[Task]: Fix cypress test suite failures caused by PR #29794 #30378: The changes made in this PR could potentially address the failures in the Cypress test suite mentioned in the issue, by expanding test coverage and improving functionality related to workspace options. The introduction of new tests and modifications in the home page interactions could align with the objectives of ensuring the test suite runs successfully and maintaining compatibility.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Aishwarya-U-R · 2024-02-26T06:23:40Z

/ci-test-limit

github-actions · 2024-02-26T06:24:14Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8044603529.
Workflow: ci-test-limited.
PR: 31270.

github-actions · 2024-02-26T06:53:59Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8044603529.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2024-02-26T07:17:36Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8044603529.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2024-02-26T07:30:25Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8044603529.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js

To know the list of identified flaky tests - Refer here

Aishwarya-U-R · 2024-02-26T07:31:02Z

/ci-test-limit runId=8044603529

github-actions · 2024-02-26T07:31:33Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8045203463.
Workflow: ci-test-limited.
PR: 31270.

Aishwarya-U-R · 2024-02-26T07:31:56Z

/ci-test-limit runId=8044603529

github-actions · 2024-02-26T07:32:28Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8045212404.
Workflow: ci-test-limited.
PR: 31270.

github-actions · 2024-02-26T07:43:26Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8044603529.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2024-02-26T07:44:26Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8045203463.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2024-02-26T07:45:26Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8045212404.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2024-02-26T08:07:32Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8045212404.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Aishwarya-U-R · 2024-02-26T08:15:24Z

/ci-test-limit runId=8044603529

github-actions · 2024-02-26T08:16:02Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8045660837.
Workflow: ci-test-limited.
PR: 31270.

github-actions · 2024-02-26T08:21:37Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8045203463.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js

To know the list of identified flaky tests - Refer here

Aishwarya-U-R · 2024-02-26T08:26:07Z

/ci-test-limit runId=8044603529

github-actions · 2024-02-26T08:26:38Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8045784770.
Workflow: ci-test-limited.
PR: 31270.

github-actions · 2024-02-26T08:28:13Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8045660837.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2024-02-26T11:29:34Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8047987066.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js

To know the list of identified flaky tests - Refer here

Aishwarya-U-R · 2024-02-26T11:32:23Z

/ci-test-limit runId=8047568730

github-actions · 2024-02-26T11:32:55Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8048167163.
Workflow: ci-test-limited.
PR: 31270.

app/client/cypress/support/Pages/HomePage.ts

github-actions · 2024-02-26T11:40:42Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8048167163.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Aishwarya-U-R · 2024-02-26T11:45:45Z

/ci-test-limit runId=8047568730

Aishwarya-U-R · 2024-02-26T11:45:54Z

/ci-test-limit runId=8047568730

Aishwarya-U-R · 2024-02-26T11:46:04Z

/ci-test-limit runId=8047568730

Aishwarya-U-R · 2024-02-26T11:46:08Z

/ci-test-limit runId=8047568730

github-actions · 2024-02-26T11:46:16Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8048313541.
Workflow: ci-test-limited.
PR: 31270.

github-actions · 2024-02-26T11:46:26Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8048314966.
Workflow: ci-test-limited.
PR: 31270.

github-actions · 2024-02-26T11:46:33Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8048316080.
Workflow: ci-test-limited.
PR: 31270.

github-actions · 2024-02-26T11:46:41Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8048316982.
Workflow: ci-test-limited.
PR: 31270.

github-actions · 2024-02-26T11:54:39Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8048316080.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-02-26T11:54:44Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8048313541.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-02-26T11:54:46Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8048314966.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-02-26T11:55:14Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8048316982.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-02-26T11:56:36Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8048417557.
Workflow: ci-test-limited.
PR: 31270.

github-actions · 2024-02-26T12:38:02Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8048417557.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts
cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js
cypress/e2e/Regression/ClientSide/IDE/MaintainContext&Focus_spec.js
cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionFlow_Corner_Cases_spec.ts
cypress/e2e/Regression/ClientSide/PartialImportExport/PartialExport_Widgets_spec.ts
cypress/e2e/Regression/ClientSide/Templates/ForkTemplateToGitConnectedApp.js

To know the list of identified flaky tests - Refer here

github-actions · 2024-02-27T06:56:28Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8060812323.
Workflow: ci-test-limited.
PR: 31270.

github-actions · 2024-02-27T07:52:31Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8060812323.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts
cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js
cypress/e2e/Regression/ClientSide/IDE/MaintainContext&Focus_spec.js
cypress/e2e/Regression/ClientSide/PartialImportExport/PartialExport_Widgets_spec.ts
cypress/e2e/Regression/ClientSide/Templates/ForkTemplateToGitConnectedApp.js

To know the list of identified flaky tests - Refer here

trial fix

f8b0cef

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Tests Test issues labels Feb 26, 2024

trial fix

0dfa587

trial fix

f5fa2cb

trial fix

718750a

used helper

55dbb21

Aishwarya-U-R added 2 commits February 26, 2024 13:37

used helper

6af8ec7

used helper

24b11d2

used helper

5e561c8

used helper

423bc81

coderabbitai bot reviewed Feb 26, 2024

View reviewed changes

app/client/cypress/support/Pages/HomePage.ts Outdated Show resolved Hide resolved

run all

8a7e922

locator fix

4cae3e3

Merge branch 'release' into test/wsrenamefix

3287aa9

revert

171e7d7

Aishwarya-U-R requested a review from Parthvi12 February 27, 2024 08:07

Parthvi12 approved these changes Feb 27, 2024

View reviewed changes

Aishwarya-U-R merged commit c1bfd08 into release Feb 27, 2024
13 checks passed

Aishwarya-U-R deleted the test/wsrenamefix branch February 27, 2024 08:55

test: Cypress | Flaky fixes #31270

test: Cypress | Flaky fixes #31270

Conversation

Aishwarya-U-R commented Feb 26, 2024 • edited Loading

Description

Type of change

Testing

How Has This Been Tested?

Checklist:

QA activity:

Summary by CodeRabbit

coderabbitai bot commented Feb 26, 2024 • edited Loading

Walkthrough

Changes

Related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

Aishwarya-U-R commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

Aishwarya-U-R commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

Aishwarya-U-R commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

Aishwarya-U-R commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

Aishwarya-U-R commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

Aishwarya-U-R commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

Aishwarya-U-R commented Feb 26, 2024

Aishwarya-U-R commented Feb 26, 2024

Aishwarya-U-R commented Feb 26, 2024

Aishwarya-U-R commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

Aishwarya-U-R commented Feb 26, 2024 •

edited

Loading

coderabbitai bot commented Feb 26, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)