Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cypress scroll on trigger events #31248

Merged
merged 5 commits into from
Feb 23, 2024
Merged

fix: Cypress scroll on trigger events #31248

merged 5 commits into from
Feb 23, 2024

Conversation

albinAppsmith
Copy link
Collaborator

@albinAppsmith albinAppsmith commented Feb 22, 2024 •
edited by coderabbitai bot
Loading

Description

This PR fixes the cypress failure issue due to scroll.

PR fixes following issue(s)

Fixes #31263

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

  • Refactor
    • Updated the handling of mouse events in the Entity Explorer to improve user interaction with draggable elements.
  • Tests
    • Added a new test spec for exporting applications and updated the test spec for forking applications in the limited tests configuration.

@github-actions github-actions bot added the Bug Something isn't working label Feb 22, 2024
@albinAppsmith
Copy link
Collaborator Author

/ok-to-test tags="@tag.All"

@github-actions GitHub Actions
Copy link

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8003710529.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8003710529.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/Apps/PromisesApp_spec.js

  2. cypress/e2e/Regression/ClientSide/ActionExecution/PostWindowMessage_spec.ts
  3. cypress/e2e/Regression/ClientSide/ActionExecution/setInterval_spec.js
  4. cypress/e2e/Regression/ClientSide/ActionExecution/uiToCode_spec.ts
  5. cypress/e2e/Regression/ClientSide/Autocomplete/Bugs_AC_Spec.ts
  6. cypress/e2e/Regression/ClientSide/Binding/TableV2_ClientSide_Search_spec.js
  7. cypress/e2e/Regression/ClientSide/Binding/Table_ClientSide_Search_spec.js
  8. cypress/e2e/Regression/ClientSide/Binding/Table_Widget_API_Pagination_spec.js
  9. cypress/e2e/Regression/ClientSide/BugTests/AllWidgets_Reset_Spec.ts
  10. cypress/e2e/Regression/ClientSide/BugTests/DS_Bug26716_Spec.ts
  11. cypress/e2e/Regression/ClientSide/BugTests/DS_Bug28750_Spec.ts
  12. cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts
  13. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts
  14. cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
  15. cypress/e2e/Regression/ClientSide/DynamicHeight/DynamicHeight_Visibility_spec.ts
  16. cypress/e2e/Regression/ClientSide/DynamicHeight/Form_With_SwitchGroup_spec.ts
  17. cypress/e2e/Regression/ClientSide/DynamicHeight/JsonForm_spec.ts
  18. cypress/e2e/Regression/ClientSide/DynamicHeight/Multiple_Container_spec.ts
  19. cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
  20. cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
  21. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  22. cypress/e2e/Regression/ClientSide/JSLibrary/Library_spec.ts
  23. cypress/e2e/Regression/ClientSide/Linting/BasicLint_spec.ts
  24. cypress/e2e/Regression/ClientSide/Linting/ErrorReporting_spec.ts
  25. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionFlow_Corner_Cases_spec.ts
  26. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionFlow_Generated_App_spec.ts
  27. cypress/e2e/Regression/ClientSide/Onboarding/StartFromData_spec.ts
  28. cypress/e2e/Regression/ClientSide/Onboarding/StartFromScratch_spec.ts
  29. cypress/e2e/Regression/ClientSide/OneClickBinding/JSONFormWidget/ConnectToWidget_spec.ts
  30. cypress/e2e/Regression/ClientSide/OneClickBinding/JSONFormWidget/FieldConfigModal_spec.ts
  31. cypress/e2e/Regression/ClientSide/OneClickBinding/JSONFormWidget/postgres_spec.ts
  32. cypress/e2e/Regression/ClientSide/OneClickBinding/MultiSelectWidget/mongoDB_spec.ts
  33. cypress/e2e/Regression/ClientSide/OneClickBinding/MultiSelectWidget/postgres_spec.ts
  34. cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts
  35. cypress/e2e/Regression/ClientSide/OneClickBinding/SelectWidget/mongoDB_spec.ts
  36. cypress/e2e/Regression/ClientSide/OneClickBinding/SelectWidget/postgres_spec.ts
  37. cypress/e2e/Regression/ClientSide/OneClickBinding/TableWidget/mongoDB_spec.ts
  38. cypress/e2e/Regression/ClientSide/OneClickBinding/TableWidget/postgres_spec.ts
  39. cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts
  40. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Logs2_spec.js
  41. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Widget_Error_spec.js
  42. cypress/e2e/Regression/ClientSide/PeekOverlay/PeekOverlay_Spec.ts
  43. cypress/e2e/Regression/ClientSide/Templates/Filtering/TemplatesModal_filtering_spec.ts
  44. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js
  45. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_To_App_spec.ts
  46. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js
  47. cypress/e2e/Regression/ClientSide/Widgets/Camera/Image_Spec.ts
  48. cypress/e2e/Regression/ClientSide/Widgets/Camera/Video_Spec.ts
  49. cypress/e2e/Regression/ClientSide/Widgets/Chart/Chart_widget_spec_2.ts
  50. cypress/e2e/Regression/ClientSide/Widgets/Chart/Custom3DChartSpec.ts
  51. cypress/e2e/Regression/ClientSide/Widgets/CurrencyInput/CurrencyInputDynamicCurrencyCode_spec.js
  52. cypress/e2e/Regression/ClientSide/Widgets/CurrencyInput/CurrencyInputTest.ts
  53. cypress/e2e/Regression/ClientSide/Widgets/CurrencyInput/CurrencyInput_spec.js
  54. cypress/e2e/Regression/ClientSide/Widgets/Dropdown/Dropdown_onOptionChange_spec.js
  55. cypress/e2e/Regression/ClientSide/Widgets/Filepicker/FilePicker2_spec.js
  56. cypress/e2e/Regression/ClientSide/Widgets/Input/Input_Multiline_spec.js
  57. cypress/e2e/Regression/ClientSide/Widgets/Input/Inputv2_spec.js
  58. cypress/e2e/Regression/ClientSide/Widgets/JSONForm/JSONForm_ArrayField_spec.js
  59. cypress/e2e/Regression/ClientSide/Widgets/JSONForm/JSONForm_FormBindings_spec.js
  60. cypress/e2e/Regression/ClientSide/Widgets/JSONForm/JSONForm_Reset_spec.js
  61. cypress/e2e/Regression/ClientSide/Widgets/ListV2/DataIdentifierProperty_spec.ts
  62. cypress/e2e/Regression/ClientSide/Widgets/ListV2/ListV2_SerververSide_spec.js
  63. cypress/e2e/Regression/ClientSide/Widgets/Migration_Spec.js
  64. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect4_spec.js
  65. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect5_spec.ts
  66. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiTreeSelect_2_spec.ts
  67. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/Multi_Select_Tree_spec.js
  68. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/RTL_support.ts
  69. cypress/e2e/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts
  70. cypress/e2e/Regression/ClientSide/Widgets/PhoneInput/PhoneInput_Part2_spec.ts
  71. cypress/e2e/Regression/ClientSide/Widgets/Select/RTL_support.ts
  72. cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts
  73. cypress/e2e/Regression/ClientSide/Widgets/Select/Select_spec.js
  74. cypress/e2e/Regression/ClientSide/Widgets/Switch/SwitchGroup1_spec.ts
  75. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableBugs_Spec.ts
  76. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_Button_Icon_validation_spec.js
  77. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_PropertyPane_1_spec.js
  78. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_PropertyPane_2_spec.js
  79. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_PropertyPane_IconName_spec.js
  80. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_Widget_Add_button_spec.js
  81. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_tabledata_schema_spec.js
  82. cypress/e2e/Regression/ClientSide/Widgets/TableV2/AddNewRow1_spec.js
  83. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Custom_column_alias_spec.js
  84. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Date_column_editing_1_spec.ts
  85. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_1_spec.js
  86. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_3_spec.js
  87. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter1_1_Spec.ts
  88. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter1_2_Spec.ts
  89. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_1_Spec.ts
  90. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts
  91. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_Button_Icon_validation_spec.js
  92. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_Column_Order_spec.js
  93. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_DisplayText_spec.ts
  94. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_GeneralProperty_spec.js
  95. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_PropertyPane_1_spec.js
  96. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_PropertyPane_2_spec.js
  97. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_Widget_Add_button_spec.js
  98. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_Widget_Default_Row_spec.js
  99. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_pagination_spec.js
  100. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_spec.js
  101. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Text_wrapping_spec.js
  102. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Select1_spec.ts
  103. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Select2_spec.ts
  104. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/checkboxCell_spec.js
  105. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/menubutton_spec.js
  106. cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/switchCell_spec.js
  107. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column1_spec.js
  108. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column2_spec.js
  109. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column3_spec.js
  110. cypress/e2e/Regression/ClientSide/Widgets/TableV2/inline_editing_validations_spec.js
  111. cypress/e2e/Regression/ClientSide/Widgets/TableV2/non_ascii_column_name_spec.js
  112. cypress/e2e/Regression/ClientSide/Widgets/TableV2/server_side_filtering_spec_1.ts
  113. cypress/e2e/Regression/ClientSide/Widgets/TreeSelect/Single_Select_Tree_spec.ts
  114. cypress/e2e/Regression/ClientSide/Widgets/WidgetCanvas_spec.js
  115. cypress/e2e/Regression/ClientSide/Widgets/Widgets_Labels_spec.js
  116. cypress/e2e/Regression/ServerSide/ApiTests/API_Styles_spec.js
  117. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
  118. cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres2_Spec.ts
  119. cypress/e2e/Regression/ServerSide/MySQL_Datatypes/Basic_Spec.ts
  120. cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js
  121. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Numeric_Spec.ts
  122. cypress/e2e/Regression/ServerSide/QueryPane/Mongo_Spec.js
  123. cypress/e2e/Sanity/Datasources/MockDBs_Spec.ts
  124. cypress/e2e/Sanity/Datasources/Styles_spec.js
  125. cypress/e2e/Smoke/GenerateCRUD/Generate_Crud_New_Page_spec.ts
To know the list of identified flaky tests - Refer here

@albinAppsmith
Copy link
Collaborator Author

/ok-to-test tags="@tag.All"

@github-actions GitHub Actions
Copy link

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8004573198.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8004573198.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/ExplorerTests/DragAndDropWidget_spec.js

  2. cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
  3. cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js
  4. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/FillwidgetResizingSpec.js
  5. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js
  6. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Replay_spec.js
  7. cypress/e2e/Regression/ClientSide/ThemingTests/Basic_spec.js
  8. cypress/e2e/Regression/ClientSide/Widgets/CodeScanner/CodeScanner1_spec.ts
  9. cypress/e2e/Regression/ClientSide/Widgets/Filepicker/FilePickerV2_CSV_spec.js
  10. cypress/e2e/Regression/ClientSide/Widgets/Input/Input_OnFocus_OnBlur_spec.js
  11. cypress/e2e/Regression/ClientSide/Widgets/JSONForm/JSONForm_Basic_spec.js
  12. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/Multi_Select_Tree_spec.js
  13. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_tabledata_schema_spec.js
  14. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Custom_column_alias_spec.js
  15. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_tabledata_schema_spec.js
  16. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column1_spec.js
  17. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column2_spec.js
  18. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column3_spec.js
  19. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column_query_change_spec.js
  20. cypress/e2e/Regression/ClientSide/Widgets/TableV2/non_ascii_column_name_spec.js
  21. cypress/e2e/Regression/ServerSide/QueryPane/Postgres_Spec.js
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8004573198.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/ExplorerTests/DragAndDropWidget_spec.js

  2. cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts
  3. cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js
  4. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/FillwidgetResizingSpec.js
  5. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js
  6. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Replay_spec.js
  7. cypress/e2e/Regression/ClientSide/ThemingTests/Basic_spec.js
  8. cypress/e2e/Regression/ClientSide/Widgets/CodeScanner/CodeScanner1_spec.ts
  9. cypress/e2e/Regression/ClientSide/Widgets/Filepicker/FilePickerV2_CSV_spec.js
  10. cypress/e2e/Regression/ClientSide/Widgets/Input/Input_OnFocus_OnBlur_spec.js
  11. cypress/e2e/Regression/ClientSide/Widgets/JSONForm/JSONForm_Basic_spec.js
  12. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/Multi_Select_Tree_spec.js
  13. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_tabledata_schema_spec.js
  14. cypress/e2e/Regression/ClientSide/Widgets/TableV2/Custom_column_alias_spec.js
  15. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_tabledata_schema_spec.js
  16. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column1_spec.js
  17. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column2_spec.js
  18. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column3_spec.js
  19. cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column_query_change_spec.js
  20. cypress/e2e/Regression/ClientSide/Widgets/TableV2/non_ascii_column_name_spec.js
  21. cypress/e2e/Regression/ServerSide/QueryPane/Postgres_Spec.js
To know the list of identified flaky tests - Refer here

@albinAppsmith
Copy link
Collaborator Author

/ok-to-test tags="@tag.All"

@github-actions GitHub Actions
Copy link

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8006253811.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8006253811.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts

  2. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js
  3. cypress/e2e/Regression/ClientSide/SetProperty/WidgetPropertySetters1_spec.ts
  4. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/RTL_support.ts
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8006253811.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts

  2. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8006253811.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts

  2. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8006253811.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts

  2. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js
To know the list of identified flaky tests - Refer here

@albinAppsmith albinAppsmith marked this pull request as ready for review February 23, 2024 06:02
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2024 •
edited
Loading

Walkthrough

This update involves modifications to the Cypress test support files to enhance test stability and accuracy by preventing unintended scroll behaviors during test execution. Specifically, it introduces a scrollBehavior configuration set to false in both the EntityExplorer class and the dragAndDropToCanvas function, ensuring that automated actions such as mouse movements and mouse-ups do not trigger scrolling. This change aims to address issues where tests may fail due to unexpected scrolling, improving the reliability of the test suite.

Changes

Files Change Summary
.../cypress/support/Pages/EntityExplorer.ts
.../cypress/support/commands.js		 Added scrollBehavior: false to prevent scrolling during tests

Related issues

  • [Task]: Fix cypress test suite failures caused by PR #29794 #30378: This issue outlines failures in the Cypress test suite due to changes introduced in a previous PR, which the current PR's modifications could potentially address. The addition of scrollBehavior: false might prevent unintended scrolling that could be causing some of the described test failures, making it a candidate for linking to this PR. The reasoning is that enhancing test stability by controlling scroll behavior directly aligns with the objective of resolving test failures and maintaining compatibility with existing functionality.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Aishwarya-U-R
Aishwarya-U-R previously approved these changes Feb 23, 2024
View reviewed changes
@Aishwarya-U-R
Copy link
Contributor

/ci-test-limit

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8015530807.
Workflow: ci-test-limited.
PR: 31248.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8015530807.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts

  2. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8015530807.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts

  2. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js
To know the list of identified flaky tests - Refer here

@Aishwarya-U-R Aishwarya-U-R merged commit 201d954 into release Feb 23, 2024
13 checks passed
@Aishwarya-U-R Aishwarya-U-R deleted the cypress-scroll-fix branch February 23, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aishwarya-U-R Aishwarya-U-R Aishwarya-U-R approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] - Cypress failure on mouse move
2 participants
@albinAppsmith @Aishwarya-U-R