test: Cypress | Replacing some external api's with TED + Flaky fix #31118

Aishwarya-U-R · 2024-02-14T08:43:54Z

Description

This PR does some clean up of comments - in DeployHelper.ts
This PR replaced external image api with TED mock api in ServerSide/OnLoadTests/OnLoadActions_Spec.ts
Extrenal example api to TED in Widgets/Image/Image_spec.js
Extrenal api links in app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js to TED api's
Flaky fixes /ServerSide/LoginTests/LoginFailure_spec.js - for EE CI run failure (Added multiple Dynamic checks)
support command.js method LoginUser() - added Dynamic check
Encapsulated Datasources/Arango_Basic_Spec.ts into conditional check to run in CE alone, instead of entirely skipping, since its failing in EE due to chrome crash

Media

Type of change

Script fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Cypress CI runs

Checklist:

QA activity:

Added Test Plan Approved label after Cypress tests were reviewed

Summary by CodeRabbit

Tests
- Updated Cypress regression tests to use flower images instead of cat images for API calls.
- Modified limited test configurations to run with different spec files.
- Adjusted GitHub Actions workflow to change matrix_count values based on the event type and retrieve PR number for manual triggers.
- Updated Docker image tag in CI tests to nightly.
Refactor
- Enhanced DataManager class with new properties for flower image URLs.
- Improved EntityExplorer class method to ensure more reliable triggering of events.

coderabbitai · 2024-02-14T08:44:58Z

Warning

Rate Limit Exceeded

@Aishwarya-U-R has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 50 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between fb4ee34 and 7d1ccb9.

Walkthrough

The update focuses on transitioning from cat images to flower images in API tests, adjusting limited test configurations, refining GitHub workflow setups for builds and limited testing, and updating internal properties and methods for testing needs. These changes aim to enhance testing capabilities and workflow efficiency.

Changes

File Path	Change Summary
`app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js` `app/client/cypress/support/Objects/DataManager.ts`	Updated API calls to use flower images instead of cat images. Added `flowerImageUrl1` and `flowerImageUrl2` properties.
`app/client/cypress/limited-tests.txt`	Updated to run different spec files for limited tests.
`.github/workflows/build-client-server.yml`	Modified `matrix_count` values and added step to retrieve PR number for manual triggers.
`app/client/cypress/support/Pages/EntityExplorer.ts`	Updated `trigger` method call to include `force: true` option.
`.github/workflows/ci-test-limited.yml`	Changed Docker image tag for `appsmith/test-event-driver` to `nightly`.

Related issues

[Task]: Fix cypress test suite failures caused by PR #29794 #30378: The changes in this PR, particularly the shift in API test scenarios from cat to flower images and the adjustments in test configurations, could potentially address the Cypress test suite failures reported in the issue. These modifications are aimed at ensuring the test suite runs smoothly, potentially resolving the test failures associated with PR feat: Appsmith AI as datasource plugin #29794.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

app/client/cypress/support/Pages/DeployModeHelper.ts

Aishwarya-U-R · 2024-02-15T03:01:36Z

/ci-test-limit

github-actions · 2024-02-15T03:02:05Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7910515145.
Workflow: ci-test-limited.
PR: 31118.

github-actions · 2024-02-15T03:25:52Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7910515145.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Aishwarya-U-R · 2024-02-15T03:26:44Z