chore: Make App Sidebar Generally Available #30923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
skip-changelog
hetunandu
requested review from
a team and
ichik
and removed request for
a team
WalkthroughWalkthroughThe changes primarily focus on removing feature flags related to the App Sidebar, consolidating certain actions for simplicity, and refining the UI/UX by adjusting the rendering logic and component dependencies. This includes the removal of conditional rendering based on sidebar feature flags, simplification of routes and component logic, and streamlining the overall codebase by eliminating outdated or redundant code related to the App Sidebar feature now made generally available. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -178,6 +171,13 @@ describe("Entity Explorer tests", () => { | |||
| <WidgetsEditorEntityExplorer /> | |||
| </MockPageDSL>, | |||
| ); | |||
| const widgetsTree: any = component.queryByText("Widgets", { | |||
There was a problem hiding this comment.
Looks like a unnecessary change.
There was a problem hiding this comment.
This test is for the older Entity explorer and here it needs to expand the tree
albinAppsmith
approved these changes
Feb 7, 2024
|
/build-deploy-preview skip-test=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7810335894. |
|
Deploy-Preview-URL: https://ce-30923.dp.appsmith.com |
1 task
brayn003
pushed a commit
that referenced
this pull request
Feb 9, 2024
## Description
Makes App Sidebar Generally Available
- Removes any feature flag control for App Sidebar
- Removes any older functionalities to handle non App Sidebar IDE
versions like:
- App Settings having an open or close state
- Entity Explorer ability to be hidden
- Removes the announcement for App Sidebar
#### PR fixes following issue(s)
Fixes #29232
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Refactor**
- Streamlined component logic by consolidating functions and removing
unnecessary dependencies.
- Simplified rendering and logic flow in various editor components for
improved user experience.
- **Style**
- Enhanced styling and layout in the app settings pane and editor
sidebar components.
- **Chores**
- Improved code maintainability by cleaning up unused imports,
variables, and functions.
- **Bug Fixes**
- Addressed UI inconsistencies by removing deprecated feature flags and
adjusting component behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
sondermanish
pushed a commit
that referenced
this pull request
Mar 6, 2024
## Description
Makes App Sidebar Generally Available
- Removes any feature flag control for App Sidebar
- Removes any older functionalities to handle non App Sidebar IDE
versions like:
- App Settings having an open or close state
- Entity Explorer ability to be hidden
- Removes the announcement for App Sidebar
#### PR fixes following issue(s)
Fixes #29232
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Refactor**
- Streamlined component logic by consolidating functions and removing
unnecessary dependencies.
- Simplified rendering and logic flow in various editor components for
improved user experience.
- **Style**
- Enhanced styling and layout in the app settings pane and editor
sidebar components.
- **Chores**
- Improved code maintainability by cleaning up unused imports,
variables, and functions.
- **Bug Fixes**
- Addressed UI inconsistencies by removing deprecated feature flags and
adjusting component behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes App Sidebar Generally Available
PR fixes following issue(s)
Fixes #29232
Type of change
Summary by CodeRabbit