test: Cypress | Replace static with Dynamic waits - Part 1 by Aishwarya-U-R · Pull Request #29405 · appsmithorg/appsmith

Aishwarya-U-R · 2023-12-06T19:33:20Z

Description

Removed hard waits from below specs:
- Apps/CurrencyInputIssue_Spec.js
- ClientSide/Widgets/Modal/Modal_spec.ts (Fix & unskip)
- /Binding/TableV2_Widget_API_Pagination_spec.js
Unskip - ApiTests/API_Unique_name_spec.js
Flaky fix - TableV2_Widget_API_Pagination_spec.js
Flaky fix - /ServerSide/QueryPane/S3_1_spec.js
Removed empty ReusableHelper.ts
Improved agHelper.GetElement() to include the assertion for element presence/absence
Modified helpers/function calls to fit the above syntax of GetElement()
Improved WaitUntilEleAppear(), WaitUntilEleDisappear() to use timeout from cypress config

Type of change

Script fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Cypress CI runs

Checklist:

QA activity:

Added Test Plan Approved label after Cypress tests were reviewed

Summary by CodeRabbit

Tests
- Enhanced end-to-end test stability by replacing static waits with dynamic element-based synchronization.
- Skipped certain test suites to streamline the testing process.
- Improved test assertions and control flow for more reliable verification of UI components.
Chores
- Updated test helper methods to support new verification strategies.
- Cleaned up unnecessary imports and inheritance in test support classes.
Documentation
- Adjusted test case descriptions to reflect the new synchronization methods used.
Bug Fixes
- Fixed issues with test synchronization that could lead to flaky test results.

coderabbitai · 2023-12-06T19:33:28Z

Walkthrough

The changes across the codebase reflect a shift towards more dynamic and reliable testing practices in Cypress tests. Static sleeps have been replaced with dynamic waits, ensuring elements are present or absent before proceeding. This improves test stability and performance. Additionally, there's a move towards more direct and granular imports, removal of unused references, and updates to control flow logic. Some test suites have been skipped, indicating a possible deprioritization or refactoring of tests.

Changes

File Path	Change Summary
`.../CurrencyInputIssue_Spec.js`, `.../Modal_spec.ts`, `.../ListWidgetParseError.ts`, `.../Radio2_spec.ts`, `.../Widget_property_navigation_spec.ts`	Removed static sleep/wait calls; introduced dynamic element-based waits; updated assertions and control flow.
`.../AggregateHelper.ts`, `.../AssertHelper.ts`, `.../HomePage.ts`, `.../Table.ts`, `.../Registry.ts`	Updated helper classes with new methods and logic; removed unused imports and inheritance; commented out static sleep.
`.../RTL_support.ts`, `.../DSCrudAndBindings_Spec.ts`, `.../TableV2_Widget_API_Pagination_spec.js`, `.../ForkTemplateToGitConnectedApp.js`	Adjusted element verification logic; skipped certain test suites; updated import names and toast message handling.
`limited-tests.txt`	Updated the list of limited tests, indicating changes in test execution priorities.
`.../S3_1_spec.js`, `.../Library_spec.ts`	Modified data source creation logic in tests; shifted from global object access to direct named imports for better clarity and maintenance.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

If you reply to a review comment from CodeRabbit, the bot will automatically respond.
To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
Note: Review comments are made on code diffs or files, not on the PR overview.
Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

github-actions · 2023-12-07T08:43:14Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7125754736.
Workflow: ci-test-limited.
PR: 29405.

github-actions · 2023-12-07T09:55:48Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7125754736.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/Apps/CommunityIssues_Spec.ts
cypress/e2e/Regression/Apps/CurrencyInputIssue_Spec.js
cypress/e2e/Regression/ClientSide/Binding/SelectWidget_Spec.ts
cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js
cypress/e2e/Regression/ClientSide/Binding/TableV2TextPagination_spec.js
cypress/e2e/Regression/ClientSide/Binding/TableV2_Widget_API_Derived_Column_spec.js
cypress/e2e/Regression/ClientSide/Binding/TableV2_Widget_API_Pagination_spec.js
cypress/e2e/Regression/ClientSide/BugTests/ApiBugs_Spec.ts
cypress/e2e/Regression/ClientSide/BugTests/Bug9334_Spec.ts
cypress/e2e/Regression/ClientSide/BugTests/Moment_Spec.ts
cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
cypress/e2e/Regression/ClientSide/MobileResponsiveTests/SuggestedWidgets_spec.js
cypress/e2e/Regression/ClientSide/OneClickBinding/JSONFormWidget/ConnectToWidget_spec.ts
cypress/e2e/Regression/ClientSide/OneClickBinding/JSONFormWidget/mongoDb_spec.ts
cypress/e2e/Regression/ClientSide/OneClickBinding/JSONFormWidget/postgres_spec.ts
cypress/e2e/Regression/ClientSide/Widgets/Filepicker/FilePickerV2_CSV_spec.js
cypress/e2e/Regression/ClientSide/Widgets/List/ListWidgetParseError.ts
cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_BasicServerSideData_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/RTL_support.ts
cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableBugs_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter1_1_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter1_2_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter2_1_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter2_2_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_PropertyPane_2_spec.js
cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter1_1_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter1_2_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_1_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_DisplayText_spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_PropertyPane_1_spec.js
cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_Url_Column_spec.ts
cypress/e2e/Regression/ClientSide/Widgets/TableV2/server_side_filtering_spec_1.ts
cypress/e2e/Regression/ServerSide/Datasources/Firestore_Basic_Spec.ts
cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
cypress/e2e/Regression/ServerSide/GenerateCRUD/Mongo_Spec.ts
cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts
cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres1_Spec.ts
cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres2_Spec.ts
cypress/e2e/Regression/ServerSide/JsFunctionExecution/JSFunctionExecution_spec.ts
cypress/e2e/Regression/ServerSide/MySQL_Datatypes/Basic_Spec.ts
cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts
cypress/e2e/Regression/ServerSide/Params/PassingParams_Spec.ts
cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Array_Spec.ts
cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Binary_Spec.ts
cypress/e2e/Regression/ServerSide/Postgres_DataTypes/BooleanEnum_Spec.ts
cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Character_Spec.ts
cypress/e2e/Regression/ServerSide/Postgres_DataTypes/DateTime_Spec.ts
cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Json_Spec.ts
cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Numeric_Spec.ts
cypress/e2e/Regression/ServerSide/Postgres_DataTypes/UUID_Spec.ts
cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts
cypress/e2e/Regression/ServerSide/QueryPane/MySQL_Spec.ts
cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js
cypress/e2e/Regression/ServerSide/QueryPane/S3_2_spec.ts

To know the list of identified flaky tests - Refer here

app/client/cypress/support/Pages/AggregateHelper.ts

github-actions · 2023-12-07T10:27:08Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7126880941.
Workflow: ci-test-limited.
PR: 29405.

github-actions · 2023-12-07T11:31:26Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7126880941.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/Apps/CurrencyInputIssue_Spec.js
cypress/e2e/Regression/ClientSide/Binding/TableV2_Widget_API_Pagination_spec.js
cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts
cypress/e2e/Regression/ClientSide/Widgets/List/ListWidgetParseError.ts
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/RTL_support.ts
cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts
cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2023-12-07T12:28:57Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7128165776.
Workflow: ci-test-limited.
PR: 29405.

github-actions · 2023-12-07T12:31:02Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7128165776.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

To know the list of identified flaky tests - Refer here

github-actions · 2023-12-07T12:33:07Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7128211615.
Workflow: ci-test-limited.
PR: 29405.

app/client/cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts

github-actions · 2023-12-07T13:30:46Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7128211615.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/Apps/CurrencyInputIssue_Spec.js
cypress/e2e/Regression/ClientSide/Binding/TableV2_Widget_API_Pagination_spec.js
cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts
cypress/e2e/Regression/ServerSide/ApiTests/API_Styles_spec.js
cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2023-12-08T06:45:55Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7138297992.
Workflow: ci-test-limited.
PR: 29405.

github-actions · 2023-12-09T16:07:34Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7152107498.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Aishwarya-U-R · 2023-12-09T17:02:08Z

/ci-test-limit

github-actions · 2023-12-09T17:02:37Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7152444808.
Workflow: ci-test-limited.
PR: 29405.

Aishwarya-U-R · 2023-12-09T17:03:35Z

/ci-test-limit

github-actions · 2023-12-09T17:04:10Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7152454023.
Workflow: ci-test-limited.
PR: 29405.

github-actions · 2023-12-09T17:24:07Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7152444808.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2023-12-09T17:25:06Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7152454023.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2023-12-09T18:06:28Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7152738931.
Workflow: ci-test-limited.
PR: 29405.

github-actions · 2023-12-09T19:03:24Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7152738931.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Widgets/Chart/Chart_Widget_Loading_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2023-12-11T04:01:12Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7162726394.
Workflow: ci-test-limited.
PR: 29405.

github-actions · 2023-12-11T04:58:55Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7162726394.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2023-12-11T05:41:00Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7163410746.
Workflow: ci-test-limited.
PR: 29405.

app/client/cypress/support/Pages/AggregateHelper.ts

github-actions · 2023-12-11T06:37:10Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7163410746.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

app/client/cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts

app/client/cypress/support/Pages/HomePage.ts

sarojsarab

LGTM

CurrencyInputIssue_Spec removed wait

f5f411c

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Tests Test issues labels Dec 6, 2023

Aishwarya-U-R added 4 commits December 7, 2023 11:05

Merge branch 'release' into test/dynamicwaitremove

47a8863

GetElement improved

f959ed1

Merge branch 'release' into test/dynamicwaitremove

0471309

run all

476f5de

Aishwarya-U-R added 2 commits December 7, 2023 15:51

removed empty ReusableHelper

6c033a4

Table.ts methods fix

d6083ca

coderabbitai bot reviewed Dec 7, 2023

View reviewed changes

app/client/cypress/support/Pages/AggregateHelper.ts Show resolved Hide resolved

Merge branch 'release' into test/dynamicwaitremove

873cc7f

Aishwarya-U-R added 2 commits December 7, 2023 17:57

/Widgets/Multiselect/RTL_support.ts fix

5e1ab82

Merge branch 'release' into test/dynamicwaitremove

4d24400

fix

ac71070

eleWidth call fix

4810bdd

fix lint

9f080bb

coderabbitai bot reviewed Dec 7, 2023

View reviewed changes

app/client/cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts Show resolved Hide resolved

Aishwarya-U-R added 2 commits December 7, 2023 18:20

skipping dscrudbindings

185138c

fix lint

ae2c5de

Merge branch 'release' into test/dynamicwaitremove

544d7d3

Aishwarya-U-R added 2 commits December 9, 2023 21:17

run modal spec

a50d27d

run modal spec

d0615d5

run both

f28f80c

Aishwarya-U-R added 2 commits December 9, 2023 23:34

run all

fbb0f5c

Merge branch 'release' into test/dynamicwaitremove

bb303d4

Aishwarya-U-R added 2 commits December 11, 2023 11:07

WaitUntilEleDisappear improve

7b07fc3

Merge branch 'release' into test/dynamicwaitremove

a929615

coderabbitai bot reviewed Dec 11, 2023

View reviewed changes

app/client/cypress/support/Pages/AggregateHelper.ts Show resolved Hide resolved

clean up

247b49c

Aishwarya-U-R requested a review from sarojsarab December 11, 2023 06:55

sarojsarab suggested changes Dec 11, 2023

View reviewed changes

app/client/cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts Show resolved Hide resolved

app/client/cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts Show resolved Hide resolved

app/client/cypress/support/Pages/HomePage.ts Outdated Show resolved Hide resolved

remove comment

073b86e

Aishwarya-U-R requested a review from sarojsarab December 11, 2023 08:46

sarojsarab approved these changes Dec 11, 2023

View reviewed changes

Aishwarya-U-R merged commit fe3863e into release Dec 11, 2023

Aishwarya-U-R deleted the test/dynamicwaitremove branch December 11, 2023 09:09

coderabbitai bot mentioned this pull request Jul 24, 2025

fix: update column position check in TableV2 freeze column test #41130

Merged

2 tasks

Conversation

Aishwarya-U-R commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Testing

How Has This Been Tested?

Checklist:

QA activity:

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Uh oh!

github-actions bot commented Dec 7, 2023

Uh oh!

github-actions bot commented Dec 7, 2023

Uh oh!

Uh oh!

github-actions bot commented Dec 7, 2023

Uh oh!

github-actions bot commented Dec 7, 2023

Uh oh!

github-actions bot commented Dec 7, 2023

Uh oh!

github-actions bot commented Dec 7, 2023

Uh oh!

github-actions bot commented Dec 7, 2023

Uh oh!

Uh oh!

github-actions bot commented Dec 7, 2023

Uh oh!

github-actions bot commented Dec 8, 2023

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

Aishwarya-U-R commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

Aishwarya-U-R commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 9, 2023

Uh oh!

github-actions bot commented Dec 11, 2023

Uh oh!

github-actions bot commented Dec 11, 2023

Uh oh!

github-actions bot commented Dec 11, 2023

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarojsarab left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Aishwarya-U-R commented Dec 6, 2023 •

edited

Loading

coderabbitai bot commented Dec 6, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)