Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add failure cases for airgapped superuser creation cypress check #23778

Merged
merged 2 commits into from
May 26, 2023

Conversation

dipyamanbiswas07
Copy link
Contributor

@dipyamanbiswas07 dipyamanbiswas07 commented May 26, 2023

Description

Fix Airgapped cypress tests failing due to superuser expecting anonymousdata and newsletter to be true.

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@github-actions github-actions bot added the Bug Something isn't working label May 26, 2023
@dipyamanbiswas07
Copy link
Contributor Author

/ok-to-test sha=3879714

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5091893903.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3879714.
PR: 23778.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23778&runId=5091893903_1

@dipyamanbiswas07 dipyamanbiswas07 added skip-testPlan Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers labels May 26, 2023
@dipyamanbiswas07 dipyamanbiswas07 changed the title fix: add failure cases for airgapped superuser creation cypress check ci: add failure cases for airgapped superuser creation cypress check May 26, 2023
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog CI and removed Bug Something isn't working labels May 26, 2023
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5091893903.
Commit: 3879714.
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js

To know the list of identified flaky tests - Refer here

@dipyamanbiswas07
Copy link
Contributor Author

/ok-to-test sha=642f003

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5092648097.
Workflow: Appsmith External Integration Test Workflow.
Commit: 642f003.
PR: 23778.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23778&runId=5092648097_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5092648097.
Commit: 642f003.
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js

  2. cypress/e2e/Regression/ServerSide/ApiTests/API_CurlPOSTImport_spec.js
To know the list of identified flaky tests - Refer here

@Aishwarya-U-R Aishwarya-U-R merged commit 4cf655d into release May 26, 2023
@Aishwarya-U-R Aishwarya-U-R deleted the fix/cypress-onboarding-airgapped-fix branch May 26, 2023 17:26
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5092648097.
Commit: 642f003.
All cypress tests have passed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants