Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patches blueprint's popover #12213

Merged
merged 4 commits into from
Mar 31, 2022
Merged

fix: patches blueprint's popover #12213

merged 4 commits into from
Mar 31, 2022

Conversation

aswathkk
Copy link
Contributor

@aswathkk aswathkk commented Mar 24, 2022 •
edited by github-actions bot
Loading

Description

Patches Blueprintjs's popover based on palantir/blueprint#5080

Fixes #6194

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed No changes to code coverage between the base branch and the head branch

@aswathkk aswathkk added the UI Building Product Issues related to the UI Building experience label Mar 24, 2022
@vercel
Copy link

vercel bot commented Mar 24, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/D5u5P3B5zXU37DxVPhuVQZ3fbdMX
✅ Preview: https://appsmith-git-fix-tooltip-issue-get-appsmith.vercel.app

@aswathkk aswathkk requested a review from riodeuno March 24, 2022 09:46
@github-actions github-actions bot added the Bug Something isn't working label Mar 24, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@aswathkk
Copy link
Contributor Author

/ok-to-test sha=37258f9

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2034822002.
Workflow: Appsmith External Integration Test Workflow.
Commit: 37258f9.
PR: 12213.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2034822002.
Commit: 37258f9.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@Aishwarya-U-R
Copy link
Contributor

/ok-to-test sha=b752c0f

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2036271718.
Workflow: Appsmith External Integration Test Workflow.
Commit: b752c0f.
PR: 12213.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2036271718.
Commit: b752c0f.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@aswathkk
Copy link
Contributor Author

/ok-to-test sha=45e5aca

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2050479213.
Workflow: Appsmith External Integration Test Workflow.
Commit: 45e5aca.
PR: 12213.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2050479213.
Commit: 45e5aca.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@github-actions github-actions bot added High This issue blocks a user from building or impacts a lot of users Keyboard Shortcuts Property Pane Issues related to the behaviour of the property pane UI Building Pod labels Mar 28, 2022
@aswathkk
Copy link
Contributor Author

/ok-to-test sha=50d2f2b

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2051693447.
Workflow: Appsmith External Integration Test Workflow.
Commit: 50d2f2b.
PR: 12213.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2051693447.
Commit: 50d2f2b.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@vivekverma2312
Copy link

@aswathkk Tested and it's working fine.

@aswathkk aswathkk merged commit dfa788c into release Mar 31, 2022
@aswathkk aswathkk deleted the fix/tooltip-issue branch March 31, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riodeuno riodeuno riodeuno approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Keyboard Shortcuts Property Pane Issues related to the behaviour of the property pane UI Building Product Issues related to the UI Building experience
Projects
None yet
Milestone
No milestone
4 participants
@aswathkk @Aishwarya-U-R @vivekverma2312 @riodeuno