Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Handle delete action #36645

Closed
1 task
Tracked by #34663
ankitakinger opened this issue Oct 2, 2024 · 0 comments · Fixed by #36746
Closed
1 task
Tracked by #34663

[Task]: Handle delete action #36645

ankitakinger opened this issue Oct 2, 2024 · 0 comments · Fixed by #36746
Assignees
@ankitakinger
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo

Comments

@ankitakinger
Copy link
Contributor

SubTasks

  • Log analytics when delete button is clicked
@ankitakinger ankitakinger added the Task A simple Todo label Oct 2, 2024
@ankitakinger ankitakinger self-assigned this Oct 2, 2024
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Oct 2, 2024
This was referenced Oct 2, 2024
Open
Merged
nerbos pushed a commit that referenced this issue Oct 9, 2024
@ankitakinger
chore: Adding the functionality of running and deleting an action und…
41d5ce7 
…er modularised flow (#36746)

## Description

Adding the functionality of running and deleting an action under
modularised flow.

Fixes [#36645](#36645)
[#36644](#36644)

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11254347110>
> Commit: a1c8050
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11254347110&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.Sanity
> Spec: 
> It seems like **no tests ran** 😔. We are not able to recognize it,
please check <a
href="https://github.com/appsmithorg/appsmith/actions/runs/11254347110"
target="_blank">workflow here</a>.
> <hr>Wed, 09 Oct 2024 12:34:20 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced new hooks, `useHandleRunClick` and `useHandleDeleteClick`,
to enhance action handling for running and deleting actions.

- **Improvements**
- Updated the `APIEditorForm`, `PluginActionToolbar`, and
`PluginActionMoreActions` components to utilize the new hooks, improving
functionality and code organization.
- Enhanced the user interface for deletion actions by integrating
confirmation states and dynamic labels.
- Streamlined the `PluginActionToolbar` and `PluginActionResponse`
components for better action dispatching and menu management.

- **Bug Fixes**
- Removed unused `onTestClick` prop from various components, improving
clarity and reducing complexity.
  
- **Documentation**
- Added a new file documenting circular dependencies within the codebase
to assist developers in understanding module interrelations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
No milestone
1 participant
@ankitakinger