Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Workflow with extra JS object other than Main is failing after execution start #32239

Closed
1 task done
Parthvi12 opened this issue Mar 29, 2024 · 3 comments · Fixed by #36094
Closed
1 task done

[Bug]: Workflow with extra JS object other than Main is failing after execution start #32239

Parthvi12 opened this issue Mar 29, 2024 · 3 comments · Fixed by #36094
Assignees
@ayushpahwa
Labels
Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product

Comments

@Parthvi12
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Workflow with extra JS object other than Main is failing after execution start

Steps To Reproduce

  1. Go to workflow
  2. Create new jsobject
  3. Trigger workflow, observe it fails.

Public Sample App

No response

Environment

Release

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

Cloud
@Parthvi12 Parthvi12 added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Workflows Pod Issues that the workflows team owns labels Mar 29, 2024
@github-actions github-actions bot removed the Workflows Pod Issues that the workflows team owns label Mar 29, 2024
@Parthvi12 Parthvi12 mentioned this issue Mar 29, 2024
Open
@Nikhil-Nandagopal Nikhil-Nandagopal added Release Medium Issues that frustrate users due to poor UX labels Mar 29, 2024
@Nikhil-Nandagopal
Copy link
Contributor

Closing this as it does not have an appropriate label associated with a pod

@nidhi-nair nidhi-nair added the Workflows Product Issues related to the workflows product label Mar 29, 2024
@nidhi-nair nidhi-nair reopened this Mar 29, 2024
@github-actions github-actions bot added the Workflows Pod Issues that the workflows team owns label Mar 29, 2024
@Nikhil-Nandagopal
Copy link
Contributor

Bumping this issue up to prod because it should have made it's way there by now if it was not fixed

@ayushpahwa
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @nsarupr @srix

@infinitetrooper infinitetrooper mentioned this issue Aug 26, 2024
Closed
@ayushpahwa ayushpahwa mentioned this issue Sep 3, 2024
Merged
2 tasks
@appsmith-bot appsmith-bot added the QA Needs QA attention label Sep 4, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Sep 4, 2024
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
@ayushpahwa @Shivam-z
feat: disable create js object option in workflows editor (appsmithor…
0bb8f83 
…g#36094)

## Description

Workflows is not currently supporting multiple js objects. Hence, we
need to disable the option for the workflows editor.

EE branch: https://github.com/appsmithorg/appsmith-ee/pull/5027

Fixes appsmithorg#32239 

## Automation

/test js

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10686636668>
> Commit: 5cb101f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10686636668&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JS`
> Spec:
> <hr>Tue, 03 Sep 2024 16:45:16 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced logic for creating new JavaScript objects, preventing
unnecessary additions in the workflow editor.
- Introduced a function to determine if creating a new JavaScript object
is allowed, improving user experience in the workflow editor.
- Improved responsiveness of the Files component based on the parent
entity type, allowing for context-sensitive behavior.

- **Bug Fixes**
- Addressed limitations in workflow runner support for multiple
JavaScript objects.

- **Refactor**
- Simplified the `onCreate` function's dependencies for improved clarity
and functionality.
  
- **Tests**
- Added new test cases to validate the behavior of JavaScript object
creation options based on user settings.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayushpahwa ayushpahwa

Labels
Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: disable create js object option in workflows editor appsmithorg/appsmith
5 participants
@Nikhil-Nandagopal @nidhi-nair @ayushpahwa @appsmith-bot @Parthvi12