Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: WDS elevation system fine-tuning #29421

Closed
ichik opened this issue Dec 7, 2023 · 1 comment · Fixed by #29618
Closed

chore: WDS elevation system fine-tuning #29421

ichik opened this issue Dec 7, 2023 · 1 comment · Fixed by #29618
Assignees
@ichik
Labels
Anvil Pod Issue related to Anvil project WDS team

Comments

@ichik
Copy link
Contributor

ichik commented Dec 7, 2023

Follow-up to #29391

Consider:

  • lightness checks for seed properties (e.g. light seeds in light mode)
  • having a condition for the visibility of shadows
  • extending this to more semantics (accent, neutral etc.)
@ichik ichik added WDS team Anvil Pod Issue related to Anvil project labels Dec 7, 2023
@ichik ichik self-assigned this Dec 7, 2023
@ichik
Copy link
Contributor Author

ichik commented Dec 7, 2023

Hey team! Please add your planning poker estimate with Zenhub @jsartisan @KelvinOm

@ichik ichik mentioned this issue Dec 7, 2023
Closed
@ichik ichik mentioned this issue Dec 14, 2023
Merged
KelvinOm pushed a commit that referenced this issue Dec 14, 2023
@ichik
chore: WDS elevation colors refinement (#29618)
db493eb 
Closes #29421

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Style**
- Enhanced the visual contrast in Dark Mode by adjusting background
elevation colors for improved readability.
- Refined Light Mode background colors for better visual hierarchy based
on lightness conditions.
- Updated shadow effects on UI components to provide a more pronounced
depth and focus.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@ichik ichik mentioned this issue Dec 18, 2023
Closed
@coderabbitai coderabbitai bot mentioned this issue Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ichik ichik

Labels
Anvil Pod Issue related to Anvil project WDS team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: WDS elevation colors refinement appsmithorg/appsmith
1 participant
@ichik