Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate RTS Migration end point with AutoCommit flow #26769

Closed
AnaghHegde opened this issue Aug 30, 2023 · 0 comments · Fixed by #29439 or #29538
Closed

Integrate RTS Migration end point with AutoCommit flow #26769

AnaghHegde opened this issue Aug 30, 2023 · 0 comments · Fixed by #29439 or #29538
Assignees
@nayan-rafiq
Labels
Git Platform Pod Issues related to the git & the app platform Git Product Issues related to version control product

Comments

@AnaghHegde
Copy link
Member

AnaghHegde commented Aug 30, 2023 •
edited
Loading

  • Integrate with RTS end point for Applying the migration for the git file system resources
  • Add tests for the migration changes
  • API end point for the client to call on page load POST /auto-commit
@AnaghHegde AnaghHegde added the Git Platform Pod Issues related to the git & the app platform label Aug 30, 2023
@github-actions github-actions bot removed the Git Platform Pod Issues related to the git & the app platform label Aug 30, 2023
@AnaghHegde AnaghHegde self-assigned this Aug 30, 2023
@AnaghHegde AnaghHegde added the Git Product Issues related to version control product label Aug 30, 2023
@github-actions github-actions bot added the Git Platform Pod Issues related to the git & the app platform label Aug 30, 2023
@AnaghHegde AnaghHegde changed the title Schedule Auto Commit and push to a background job Integrate RTS Migration end point with AutoCommit flow Sep 12, 2023
@nayan-rafiq nayan-rafiq mentioned this issue Dec 7, 2023
Merged
20 tasks
@riteshkew riteshkew mentioned this issue Dec 8, 2023
Closed
nayan-rafiq pushed a commit that referenced this issue Dec 12, 2023
feat: Added auto commit feature (#29439)
6e8bfc6 
## Description
This PR adds the auto commit feature for git connected applications.

#### PR fixes following issue(s)
Fixes #26769
@nayan-rafiq nayan-rafiq mentioned this issue Dec 12, 2023
Merged
20 tasks
Aishwarya-U-R pushed a commit that referenced this issue Dec 13, 2023
chore: Added new analytics parameter for git auto commit (#29538)
d83f4e2 
## Description
A refactor in the analytics events for Git. Also adds
isSystemGenerated=false for regular commits.

#### PR fixes following issue(s)
Fixes #26769

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced Git integration with the inclusion of repository URLs in
auto-commit events.
- Improved analytics tracking by utilizing repository URLs for version
information.

- **Refactor**
- Standardized event naming by replacing string literals with enum
constants in Git-related operations.

- **Bug Fixes**
- Fixed an issue in the analytics service by correcting the method
signature for user ID hashing.

- **Documentation**
- Updated internal documentation to reflect changes in analytics and Git
service logic.

- **Tests**
- Expanded test coverage to account for new repository URL handling in
auto-commit events.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nayan-rafiq nayan-rafiq

Labels
Git Platform Pod Issues related to the git & the app platform Git Product Issues related to version control product
Projects
None yet
Milestone
No milestone
2 participants
@AnaghHegde @nayan-rafiq