Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set_sql_body helper #140

Closed
5 tasks done
tombruijn opened this issue Oct 17, 2023 · 0 comments
Closed
5 tasks done

Add set_sql_body helper #140

tombruijn opened this issue Oct 17, 2023 · 0 comments
Assignees
@tombruijn
Labels
enhancement

Comments

@tombruijn
Copy link
Member

tombruijn commented Oct 17, 2023 •
edited
Loading

Add a helper that sets a magic attribute that contains a SQL query. It will then be auto sanitized by the agent.

To do
@tombruijn tombruijn self-assigned this Oct 20, 2023
tombruijn added a commit that referenced this issue Oct 20, 2023
@tombruijn
Add set_sql_body tracing helper
3f97c9d 
Make it easier to set SQL queries as the span body attribute without
danger of storing unsanitized SQL queries.

When `set_sql_body` is used in combination with `set_body`, the
`set_sql_body` call is leading.

Part of #140
@tombruijn tombruijn mentioned this issue Oct 20, 2023
Merged
tombruijn added a commit to appsignal/appsignal-nodejs that referenced this issue Nov 2, 2023
@tombruijn
Add setSqlBody tracing helper
86ad494 
Make it easier to set SQL queries as the span body attribute without
danger of storing unsanitized SQL queries.

When `setSqlBody` is used in combination with `setBody`, the
`setSqlBody` call is leading.

Related to appsignal/appsignal-python#140

This change was made available in the agent in PR #955
tombruijn added a commit to appsignal/appsignal-nodejs that referenced this issue Nov 2, 2023
@tombruijn
Add setSqlBody tracing helper
f16c031 
Make it easier to set SQL queries as the span body attribute without
danger of storing unsanitized SQL queries.

When `setSqlBody` is used in combination with `setBody`, the
`setSqlBody` call is leading.

Related to appsignal/appsignal-python#140

This change was made available in the agent in PR #955

Part of #956
tombruijn added a commit to appsignal/appsignal-nodejs that referenced this issue Nov 2, 2023
@tombruijn
Add setSqlBody tracing helper
7ce3abb 
Make it easier to set SQL queries as the span body attribute without
danger of storing unsanitized SQL queries.

When `setSqlBody` is used in combination with `setBody`, the
`setSqlBody` call is leading.

Related to appsignal/appsignal-python#140

This change was made available in the agent in PR #955

Part of #956
@tombruijn tombruijn mentioned this issue Nov 2, 2023
Merged
tombruijn added a commit to appsignal/appsignal-nodejs that referenced this issue Nov 3, 2023
@tombruijn
Add setSqlBody tracing helper (#957)
daa8982 
Make it easier to set SQL queries as the span body attribute without
danger of storing unsanitized SQL queries.

When `setSqlBody` is used in combination with `setBody`, the
`setSqlBody` call is leading.

Related to appsignal/appsignal-python#140

This change was made available in the agent in PR #955

Part of #956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tombruijn tombruijn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tombruijn