Fix demo sample recognition by fixing the demo tag #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `demo_sample` was passed as an attribute to the `createOpenTelemetrySpan` extension function it wasn't recognized as a tag for AppSignal. The UI only recognizes tags and not root level attributes for the demo samples box. Use the attribute format described in our docs to transform the attribute into a tag. https://docs.appsignal.com/opentelemetry/custom-instrumentation/attributes.html#tag
unflxw
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
demo_samplewas passed as an attribute to thecreateOpenTelemetrySpanextension function it wasn't recognized as a tag for AppSignal. The UI only recognizes tags and not root level attributes for the demo samples box.Use the attribute format described in our docs to transform the attribute into a tag.
https://docs.appsignal.com/opentelemetry/custom-instrumentation/attributes.html#tag
Fixes https://github.com/appsignal/appsignal-server/issues/10389