Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump agent to v-de2dd6e #766

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Bump agent to v-de2dd6e #766

merged 1 commit into from
Oct 14, 2022

Conversation

tombruijn
Copy link
Member

  • Remove fallback for unknown span body. The notice about a missing extractor is now a trace level log.
  • Filter root span attributes that are set as tags, params, headers, etc.
  • Filter more root span attributes that can contain PII information.
  • Improve http extractor span name to use http.route attribute to always build the incident action name. This should avoid new incidents with HTTP POST-like naming.

[skip review]

@tombruijn tombruijn self-assigned this Oct 14, 2022
- Remove fallback for unknown span body. The notice about a missing
  extractor is now a trace level log.
- Filter root span attributes that are set as tags, params, headers,
  etc.
- Filter more root span attributes that can contain PII information.
- Improve http extractor span name to use `http.route` attribute to
  always build the incident action name. This should avoid new incidents
  with `HTTP POST`-like naming.
@tombruijn tombruijn force-pushed the bump-agent-v-de2dd6e branch from 6048058 to ffcde02 Compare October 14, 2022 13:29
@tombruijn tombruijn merged commit 23192ef into main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant