Accept all case diagnose send report confirm input #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We prompt the user with the following when running the diagnose tool: ``` Send diagnostics report to AppSignal? (Y/n): ``` When a user submits this with "Y", we do not accept it. This was because the input checker only accepted for the lowercase value. I've lowercased all input, so that "Y", "y", "N" and "n" all work like they should in this confirmation prompt. Part of appsignal/support#204
jeffkreeftmeijer
approved these changes
Jul 26, 2022
luismiramirez
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prompt the user with the following when running the diagnose tool:
When a user submits this with "Y", we do not accept it. This was because
the input checker only accepted for the lowercase value.
I've lowercased all input, so that "Y", "y", "N" and "n" all work like
they should in this confirmation prompt.
Part of https://github.com/appsignal/support/issues/204