Use high-resolution host language timer #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ All good! |
jeffkreeftmeijer
force-pushed
the
timer
branch
3 times, most recently
from
2c2add3 to
ff8d045
Compare
In order to set times from the host language, instead of relying on the agent's internal timing, this patch adds a hrTime (high-resolution time) function based on the one shipped by OpenTelemetry, and functioning through Node's built-in perf_hooks module.
Use the newly added hrTime function to set the time when starting and completing spans, if no custom time has been passed.
jeffkreeftmeijer
requested review from
thijsc,
tombruijn,
luismiramirez and
unflxw
Adding the new timer is marked as a patch release.
thijsc
approved these changes
Apr 8, 2022
luismiramirez
approved these changes
Apr 8, 2022
unflxw
approved these changes
Apr 8, 2022
tombruijn
reviewed
Apr 8, 2022
packages/nodejs/.changesets/use-high-resolution-host-language-timer.md
Outdated
Show resolved
Hide resolved
tombruijn
reviewed
Apr 8, 2022
tombruijn
approved these changes
Apr 8, 2022
It would help to avoid confusion in the future about which function to use if we remove it. |
…timer.md Co-authored-by: Tom de Bruijn <[email protected]>
Co-authored-by: Tom de Bruijn <[email protected]>
Co-authored-by: Tom de Bruijn <[email protected]>
Co-authored-by: Tom de Bruijn <[email protected]>
Since all spans are closed with explicit timestamps (using span.closeSpanWithTimestamp), span.closeSpan is no longer used, and can be removed from the extension.
|
Took your suggestions, and removed the |
tombruijn
approved these changes
Apr 13, 2022
This comment has been minimized.
This comment has been minimized.
7 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
While performing the daily checks some issues were found with this Pull Request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of falling back to the agent’s internal timer, use a high-resolution host language timer to match timings in OpenTelemetry.