Fix writable path check in diagnose #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fs.accessSync` in the `isWriteableFile` function only checked if the path was readable with `fs.constants.R_OK`. Not if it was writable with `fs.constants.W_OK`. > - `F_OK`: Flag indicating that the file is visible to the calling > process. This is useful for determining if a file exists, but says > nothing about rwx permissions. Default if no mode is specified. > - `R_OK`: Flag indicating that the file can be read by the calling > process. > - `W_OK`: Flag indicating that the file can be written by the calling > process. > - `X_OK`: Flag indicating that the file can be executed by the > calling process. This has no effect on Windows (will behave like > fs.constants.F_OK). Source: https://nodejs.org/api/fs.html#file-access-constants I've also renamed the function to `isWriteable` because it doesn't only check files, but also directories.
unflxw
approved these changes
Nov 23, 2021
luismiramirez
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fs.accessSyncin theisWriteableFilefunction only checked ifthe path was readable with
fs.constants.R_OK. Not if it was writablewith
fs.constants.W_OK.Source: https://nodejs.org/api/fs.html#file-access-constants
I've also renamed the function to
isWriteablebecause it doesn't onlycheck files, but also directories.