Read extension install status from report #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffkreeftmeijer we have no tests for failure scenarios in this repo or in the diagnose_tests repo. What was your idea about where to implement them? Should failure state tests be part of the diagnose_tests repo? |
The installation result was hardcoded to always be `success`, because previously we couldn't track it. But since PR #409 we now run the `node-gyp` command from the `extension.js` install script so we can track the installation result. Read the status from the report so the diagnose report is more accurate. Since there are more fields in case of an error or failure, print those as well if present.
tombruijn
force-pushed
the
diagnose-success
branch
from
3edab13 to
788141d
Compare
jeffkreeftmeijer
approved these changes
Oct 11, 2021
luismiramirez
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation result was hardcoded to always be
success, becausepreviously we couldn't track it. But since PR #409 we now run the
node-gypcommand from theextension.jsinstall script so we cantrack the installation result.
Read the status from the report so the diagnose report is more accurate.
Since there are more fields in case of an error or failure, print those
as well if present.