Fix Push API Key validation in diagnose report #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Push API key validation wasn't implemented previously. I've now implemented a validation by calling the AppSignal.com auth endpoint with the configured Push API key. The http(s) library doesn't a way to make synchronous requests that I could find, so I had to update the diagnose tool and script to be async, by using the async and await keywords all the way up the chain of functions. The rest of the implementation such as the coloring of the output, and storing of the result on the report, was already implemented. I've updated the diagnose tests submodule to account for this change in behavior in the tests. Fix #408
tombruijn
force-pushed
the
diagnose-push-api-key-validation
branch
from
33e4aa8 to
9bebd78
Compare
jeffkreeftmeijer
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Push API key validation wasn't implemented previously. I've now
implemented a validation by calling the AppSignal.com auth endpoint with
the configured Push API key.
The http(s) library doesn't a way to make synchronous requests that I
could find, so I had to update the diagnose tool and script to be async,
by using the async and await keywords all the way up the chain of
functions.
The rest of the implementation such as the coloring of the output, and
storing of the result on the report, was already implemented.
I've updated the diagnose tests submodule to account for this change in
behavior in the tests.
Fix #408
Depends on appsignal/diagnose_tests#5