Pass timestamp on OpenTelemetry span close #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the SpanProcessor closes a span, before this commit, it would call `span.close()`, which would call the `appsignal_close_span` function in the extension, which would override the end time passed as an argument when calling `createOpenTelemetrySpan`. To fix this, pass the end time provided by OpenTelemetry _again_ to `span.close()` when closing the span, re-wiring it so that, if a timestamp is passed, it calls `appsignal_close_span_with_timestamp` instead. This function already existed in the extension, but a NAPI bridge for it needed to be created.
luismiramirez
approved these changes
Jun 14, 2024
|
Related intercom conversation: https://app.intercom.com/a/inbox/yzor8gyw/inbox/conversation/16410700333561 |
|
@luismiramirez Thank you! :) |
unflxw
added a commit
that referenced
this pull request
Jul 4, 2024
This reverts commit 0d60a9b (#1064) This did not fix the issue for the customer that I thought it would. Furthermore, I think my whole mental model of how the spans were being closed and the timestamps being set was wrong. Either way, turns out `appsignal_close_span_with_timestamp` forces a recalculation of the span digest, which is something we don't want to do, as the span digest is calculated differently, from the OpenTelemetry extractor output, and the `SpanInProgress` instance does not have the necessary attributes to calculate it correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SpanProcessor closes a span, before this commit, it would call
span.close(), which would call theappsignal_close_spanfunction in the extension, which would override the end time passed as an argument when callingcreateOpenTelemetrySpan.To fix this, pass the end time provided by OpenTelemetry again to
span.close()when closing the span, re-wiring it so that, if a timestamp is passed, it callsappsignal_close_span_with_timestampinstead. This function already existed in the extension, but a NAPI bridge for it needed to be created.