Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some environment variables are ignored #546

Closed
unflxw opened this issue Jan 14, 2022 · 0 comments · Fixed by #548
Closed

Some environment variables are ignored #546

unflxw opened this issue Jan 14, 2022 · 0 comments · Fixed by #548
Assignees
@unflxw
Labels
bug

Comments

@unflxw
Copy link
Contributor

unflxw commented Jan 14, 2022 •
edited by tombruijn
Loading

Due to the way that the active and enableMinutelyProbes configuration options are processed in the BaseClient constructor, their values will only be taken into account when passed through the constructor's options object. This means that the APPSIGNAL_ACTIVE and APPSIGNAL_ENABLE_MINUTELY_PROBES environment variables are, in practice, ignored.

🚨 Blocked on: #547
@unflxw unflxw added the bug label Jan 14, 2022
This was referenced Jan 14, 2022
Merged
Closed
@unflxw unflxw self-assigned this Jan 17, 2022
unflxw added a commit that referenced this issue Jan 17, 2022
@unflxw
Use APPSIGNAL_ACTIVE environment value
bb62525 
Before this change, the value of the `APPSIGNAL_ACTIVE` environment
variable would never be read, as the `active` config option was
read directly from the `BaseClient` constructor. After this change,
the option is read from the `Config` object, after it has been
initialised in the constructor.

Fixes #546.
@unflxw unflxw mentioned this issue Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unflxw unflxw

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use APPSIGNAL_ACTIVE environment value appsignal/appsignal-nodejs
1 participant
@unflxw