Add query params to diagnose report transmission (#481)

The query params to submit the diagnose report weren't included. This way it matches the other integrations.
appsignal · Nov 4, 2021 · c750216 · c750216
1 parent c04874f
commit c750216
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/packages/nodejs/.changesets/send-diagnose-report-with-correct-query-params.md b/packages/nodejs/.changesets/send-diagnose-report-with-correct-query-params.md
@@ -0,0 +1,5 @@
+---
+bump: "patch"
+---
+
+Send the diagnose report with correct query parameters to help link the report to the app and organization on AppSignal.com.
diff --git a/packages/nodejs/src/diagnose.ts b/packages/nodejs/src/diagnose.ts
@@ -199,7 +199,12 @@ export class DiagnoseTool {
     const json = JSON.stringify({ diagnose: data })
 
     const config = this.#config.data
-    const params = new URLSearchParams({ api_key: config["apiKey"] || "" })
+    const params = new URLSearchParams({
+      api_key: config["apiKey"] || "",
+      name: config["name"] || "",
+      environment: config["environment"] || "",
+      hostname: config["hostname"] || ""
+    })
 
     const diagnoseEndpoint =
       process.env.APPSIGNAL_DIAGNOSE_ENDPOINT || "https://appsignal.com/diag"

diff --git a/test/integration/diagnose b/test/integration/diagnose
+1 −0		.ruby-version
+2 −1		Gemfile
+3 −1		Gemfile.lock
+136 −31		spec/diagnose_spec.rb
+14 −3		spec/support/runner.rb