Update install report location to ext directory

In PR #545 we've merged the nodejs-ext package into the nodejs package.
It no longer fails the package install on extension installation
failure, which means the ext directory remains after a installation
failure.

We can now store the install report file in the package's `ext`
directory, like we do in all the other integrations. This means we no
longer need to generate a filename for the install report to store it in
the system tmp directory.

Closes #550

packages/nodejs/.changesets/update-install-report-path.md

@@ -0,0 +1,6 @@
+---
+bump: "patch"
+type: "change"
+---
+
+Update install report path location. The "nodejs" package now stores the install report in its own package path, with the rest of the extension files. This makes it easier to access by the diagnose report.

packages/nodejs/.gitignore

@@ -79,3 +79,4 @@ build/
 /ext/appsignal.version
 /ext/libappsignal.a
 /ext/libappsignal.dylib
+/ext/*.report

packages/nodejs/scripts/extension/report.js

@@ -80,13 +80,7 @@ function createDownloadReport(report) {
 // This implementation should match the `packages/nodejs/src/diagnose.ts`
 // implementation to generate the same path.
 function reportPath() {
-  // Navigate up to the app dir. Move up the scripts dir, package dir,
-  // @appsignal dir and node_modules dir.
-  const appPath = path.join(__dirname, "../../../../../")
-  const hash = crypto.createHash("sha256")
-  hash.update(appPath)
-  const reportPathDigest = hash.digest("hex")
-  return path.join(`/tmp/appsignal-${reportPathDigest}-install.report`)
+  return path.join(__dirname, "../../ext/install.report")
 }
 
 module.exports = {

packages/nodejs/src/__tests__/diagnose.test.ts

@@ -42,6 +42,49 @@ describe("DiagnoseTool", () => {
       expect(install).toHaveProperty("language")
       expect(install).toHaveProperty("result")
     })
+
+    it("returns an error report on failure to read the install report", async () => {
+      const fsReadSpy = jest
+        .spyOn(fs, "readFileSync")
+        .mockImplementation(() => {
+          throw new Error("uh oh")
+        })
+      const output = await tool.generate()
+
+      const install = output.installation
+      expect(install).toMatchObject({
+        parsing_error: {
+          error: expect.any(String),
+          backtrace: expect.any(Array)
+        }
+      })
+      expect(install).not.toHaveProperty("build")
+      expect(install).not.toHaveProperty("download")
+      expect(install).not.toHaveProperty("host")
+      expect(install).not.toHaveProperty("language")
+      expect(install).not.toHaveProperty("result")
+    })
+
+    it("returns an error report on failure to parse the install report", async () => {
+      const fsReadSpy = jest
+        .spyOn(fs, "readFileSync")
+        .mockImplementation(() => "not JSON")
+      const output = await tool.generate()
+
+      const install = output.installation
+      expect(install).toMatchObject({
+        parsing_error: {
+          error: expect.any(String),
+          backtrace: expect.any(Array),
+          raw: "not JSON"
+        }
+      })
+      expect(install).not.toHaveProperty("build")
+      expect(install).not.toHaveProperty("download")
+      expect(install).not.toHaveProperty("host")
+      expect(install).not.toHaveProperty("language")
+      expect(install).not.toHaveProperty("result")
+    })
   })
 
   it("returns the log_dir_path", async () => {

packages/nodejs/src/diagnose.ts

@@ -268,13 +268,7 @@ export class DiagnoseTool {
 // This implementation should match the `scripts/extension/report.js`
 // implementation to generate the same path.
 function reportPath(): string {
-  // Navigate up to the app dir. Move up the src dir, package dir, @appsignal
-  // dir and node_modules dir.
-  const appPath = path.join(__dirname, "../../../../")
-  const hash = createHash("sha256")
-  hash.update(appPath)
-  const reportPathDigest = hash.digest("hex")
-  return path.join(`/tmp/appsignal-${reportPathDigest}-install.report`)
+  return path.join(__dirname, "../ext/install.report")
 }
 
 function getPathType(stats: fs.Stats) {