-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Standardize key validation request (#485)
Add the other query params to the auth request. Update the error message to be standard for all integrations. Not all integrations necessarily have the response status code on error, so make sure all integrations start with "Failed to validate". I removed the empty JSON body from the request, because we don't parse the body in this request and our test server interpreted it as the parameter `{}` with the value of an empty String. Add test for diagnose Push API key output and report. Update the diagnose tests with tests for the Push API key validation in the diagnose CLI.
- Loading branch information
Showing
3 changed files
with
16 additions
and
5 deletions.
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
packages/nodejs/.changesets/standardize-diagnose-validation-error-message.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
bump: "patch" | ||
--- | ||
|
||
Standardize diagnose validation failure message. Explain the diagnose request failed and why. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule diagnose
updated
4 files
+1 −1 | ruby/config/appsignal.yml | |
+81 −14 | spec/diagnose_spec.rb | |
+7 −6 | spec/spec_helper.rb | |
+41 −8 | spec/support/server.rb |