Show extension load error on require

Before this commit, any errors in loading the extension wrapper
module wouldn't be shown if the `Extension` object wasn't started,
and the `BaseClient` object would not attempt to start the
extension if the extension wrapper wasn't loaded, meaning that
errors in loading the extension wrapper were, in practice, never
shown.

This commit changes those errors to be emitted when the extension
wrapper module is required, instead of when the `Extension` object
is started.

packages/nodejs/.changesets/show-extension-load-errors-when-required.md

@@ -0,0 +1,6 @@
+---
+bump: "patch"
+type: "fix"
+---
+
+Show errors in loading the extension when the `@appsignal/nodejs` module is required.

packages/nodejs/src/__tests__/extension.failure.test.ts

@@ -11,18 +11,26 @@ describe("Extension", () => {
     ext.stop()
   })
 
+  it("logs a warning when the module is required", () => {
+    const errorSpy = jest.spyOn(console, "error")
+
+    jest.resetModules()
+    require("../extension")
+
+    expect(errorSpy).toHaveBeenLastCalledWith(
+      "AppSignal extension not loaded. This could mean that your current " +
+        "environment isn't supported, or that another error has occurred."
+    )
+  })
+
   it("is not loaded", () => {
     expect(Extension.isLoaded).toEqual(false)
   })
 
   it("does not start the client", () => {
-    const warnSpy = jest.spyOn(console, "warn")
     expect(() => {
       ext.start()
     }).not.toThrow()
-    expect(warnSpy).toHaveBeenLastCalledWith(
-      "AppSignal extension not loaded. This could mean that your current environment isn't supported, or that another error has occurred."
-    )
   })
 
   it("does not error on stopping the client", () => {

packages/nodejs/src/extension.ts

@@ -16,19 +16,7 @@ export class Extension {
    * Starts the extension.
    */
   public start() {
-    try {
-      extension.start()
-    } catch (e) {
-      if (e.message === "Extension module not loaded") {
-        console.warn(
-          "AppSignal extension not loaded. This could mean that your current environment isn't supported, or that another error has occurred."
-        )
-      } else {
-        console.error(
-          `Failed to load AppSignal extension with error: ${e.message}. Please email us at [email protected] for support.`
-        )
-      }
-    }
+    extension.start()
   }
 
   /**

packages/nodejs/src/extension_wrapper.ts

@@ -6,12 +6,15 @@ try {
   mod = require("../build/Release/extension.node") as ExtensionWrapper
   mod.isLoaded = true
 } catch (e) {
+  console.error(
+    "AppSignal extension not loaded. This could mean that your current " +
+      "environment isn't supported, or that another error has occurred."
+  )
+
   mod = {
     isLoaded: false,
     extension: {
-      start() {
-        throw new Error("Extension module not loaded")
-      },
+      start() {},
       stop() {},
       diagnoseRaw() {},
       runningInContainer() {}