Don't include certificate info message templ for unavailable cert status - #7
Merged
bryanlandia merged 1 commit intoFeb 13, 2018
Conversation
Contributor
Author
|
I realized my change in edx-platform would not take effect because of this this theme template override. I'm hoping to get this pushed out to at least one prod instance next week before my vacation Feb 15, so I'd appreciate a quick look @melvinsoft @grozdanowski ~~~thanks!~~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This duplicates a change made to edx-platform in the base
_dashboard_course_listing.htmltemplate. Here's that PR (currently merged toappsembler/ficus/develop)appsembler/edx-platform#199
A previous PR to edx-platform changed the default certificate status for open-ended courses (courses with no end date) to 'unavailable', instead of 'processing'. This got rid of the confusing message 'Final course details are being wrapped up' under the course listing on the dashboard. This goes one step further and makes sure open-ended courses that have not been completed don't produce any kind of cert. message on the dashboard. Basically, this just gets rid of a styled grey
I may want to refactor this one for Ginkgo, onward. There's a comment in the code about that.