backporting https://github.com/edx/edx-platform/pull/27359 - #931
Merged
amirtds merged 1 commit intoJun 21, 2021
Conversation
|
@amirtds Is this a draft PR still or would you like a review? |
Author
|
Thanks @bryanlandia for checking, this is still WIP forgot to label it. |
amirtds
changed the title
amirtds
force-pushed
the
appsembler/ginkgo/sga-persistent-grading
branch
2 times, most recently
from
June 18, 2021 20:33
77bf5d2 to
d953aba
Compare
amirtds
changed the title
bryanlandia
self-requested a review
June 18, 2021 21:26
bryanlandia
suggested changes
Jun 18, 2021
bryanlandia
left a comment
bryanlandia
left a comment
There was a problem hiding this comment.
It looks like the change to the function signature (adding user_id) of VisibleBlocks here will break VisibleBlocks.bulk_get_or_create at https://github.com/appsembler/edx-platform/pull/931/files#diff-140e988679cdc0fe6c24f365fb6e0d42036db5ca6af2008e4c64f66f5ddcfaf0R281 . I would take a look upstream in earlier commits and see where else calls to VisibleBlocks.bulk_get_or_create might break. bulk_get_or_create will also need user_id as a param to be able to pass to bulk_create.
amirtds
force-pushed
the
appsembler/ginkgo/sga-persistent-grading
branch
from
June 21, 2021 18:46
d953aba to
41269a6
Compare
bryanlandia
self-requested a review
June 21, 2021 20:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.