Refactor course.certificates_display_behavior to add a setting - #855
Merged
Conversation
OmarIthawi
marked this pull request as ready for review
March 22, 2021 17:21
OmarIthawi
force-pushed
the
omar/certs-with-info
branch
from
March 27, 2021 14:02
9c185aa to
16d54a2
Compare
TAHOE_CERTIFICATE_DISPLAY_BEHAVIOUR allows customizing the default value. This changes the default from `end` to `early_with_info`. More context from CSMs: currently-running Tahoe courses that involve certificates have changed so that users who achieve a passing grade can’t currently access their certificate until the course ends. For essentially all of our customers, `end` is definitely not the preferred behavior.
OmarIthawi
force-pushed
the
omar/certs-with-info
branch
from
March 27, 2021 14:04
16d54a2 to
7dd507a
Compare
thraxil
approved these changes
Mar 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request mostly pay a minor tech-debt without noticeable changes. It paves the way for customizing the value for Tahoe Clusters.
TAHOE_CERTIFICATE_DISPLAY_BEHAVIOURallows customizing the default value. This changes the default fromendtoearly_with_infoTests
This PR does not enable tests for
test_course_module.pybut adds a test case for future reference.The tests will be enabled (low priority) in another PR: #860