Skip to content

honeycomb setup (celery) - #851

Closed
thraxil wants to merge 1 commit into
mainfrom
celery-honeycomb-juniper
Closed

honeycomb setup (celery)#851
thraxil wants to merge 1 commit into
mainfrom
celery-honeycomb-juniper

Conversation

@thraxil

@thraxil thraxil commented Mar 18, 2021

Copy link
Copy Markdown

Re-enable basic honeycomb tracing on celery tasks.

Re-enable basic honeycomb tracing on celery tasks.
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.0005%) to 40.145% when pulling 323c750 on celery-honeycomb-juniper into 3538598 on main.

@thraxil
thraxil marked this pull request as ready for review March 18, 2021 11:37

@OmarIthawi OmarIthawi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thraxil! I see that I've given you a false alarm 😒

I don't think we needed it since a similar code is already in:

# Honeycomb
settings.HONEYCOMB_DATASET = settings.AUTH_TOKENS.get('HONEYCOMB_DATASET', None)
settings.HONEYCOMB_WRITEKEY = settings.AUTH_TOKENS.get('HONEYCOMB_WRITEKEY', None)

Please let me know if you still think this is needed.

@thraxil

thraxil commented Mar 19, 2021

Copy link
Copy Markdown
Author

@OmarIthawi I see lms-celery traces in Honeycomb from Juniper staging, so it does appear that it's already working and we don't need this.

@thraxil thraxil closed this Mar 19, 2021
@OmarIthawi
OmarIthawi deleted the celery-honeycomb-juniper branch March 19, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants