Juniper upgrade - Studio local login - #847
Merged
Merged
Conversation
This commit adds Studio local login as an optional setting. When `settings.FEATURES['STUDIO_LOCAL_LOGIN'] == True` then Studio logins do not redirect to login via the LMS. Instead they log in locally If this setting is `False` or does not exit, then the default login scheme is used. This commit adds the following: - A new feature to the CMS settings.FEATURES: `STUDIO_LOCAL_LOGIN` - Conditionally include CMS `appsembler.urls` to the CMS project level urls - Conditionall update login and logout settings in `cms/envs/production.py` to assign URL settings for Studio local login - Add URL dispatcher urls and login view and support code to CMS `appsembler` app TODO: Add unit tests for the new `appsembler` modules
OmarIthawi
reviewed
Mar 17, 2021
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
Thanks @johnbaldwin. Please add tests and this should be ready to go!
OmarIthawi
approved these changes
Mar 17, 2021
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
Let's merge it and add tests later. Thanks for the reminder @johnbaldwin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds Studio local login as an optional setting.
When
settings.FEATURES['STUDIO_LOCAL_LOGIN'] == Truethen Studio logins do not redirect to login via the LMS. Instead they log in locallyIf this setting is
Falseor does not exit, then the default login scheme is used.This commit adds the following:
STUDIO_LOCAL_LOGINappsembler.urlsto the CMS project level urlscms/envs/production.pyto assign URL settings for Studio local loginappsemblerappTODO: Add unit tests for the new
appsemblermodules