Skip to content

get_active_sites() to return QuerySet - #815

Merged
OmarIthawi merged 1 commit into
appsembler/tahoe/developfrom
omar/sites-queryset
Feb 4, 2021
Merged

get_active_sites() to return QuerySet#815
OmarIthawi merged 1 commit into
appsembler/tahoe/developfrom
omar/sites-queryset

Conversation

@OmarIthawi

Copy link
Copy Markdown
  • added tests
  • added order_by parameter
  • refactored _get_active_tiers_uuids to isolate the Tiers import

This PR addresses an indirect bug in which Figures expects a QuerySet:

do_update_enrollment_data = False if date_for < today else True
    sites = get_sites()
    sites_count = sites.count()
    ^

TypeError: count() takes exactly one argument (0 given)

 - added tests
 - added order_by parameter
 - refactored `_get_active_tiers_uuids` to isolate the Tiers import
@OmarIthawi
OmarIthawi merged commit 2da4dbf into appsembler/tahoe/develop Feb 4, 2021
@OmarIthawi
OmarIthawi deleted the omar/sites-queryset branch February 4, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants