Allow auto-generation of certs (e.g., on passing grade) for Honor mode - #794
Merged
bryanlandia merged 1 commit intoDec 28, 2020
Conversation
Author
|
Also, auto-cert generation isn't turned on for Tahoe SaaS anyhow (probably because it requires PersistentGrades), but we are using it for DHIS2 on Tahoe standalone. Some info on enabling it is here https://appsembler.atlassian.net/wiki/spaces/BLA/pages/62652425/DHIS2+Hawthorn+upgrade+plan#1b.-Manual-configuration |
OmarIthawi
suggested changes
Dec 23, 2020
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
Thanks @bryanlandia! This is helpful!
Please add a feature flag for it so it's maintainable and we can quickly find the related code for it.
We'll also need to add something like this in the Tahoe settings overrides openedx/core/djangoapps/appsembler/settings/settings/common.py:
# Appsembler allows generating honor certs
settings.FEATURES['TAHOE_AUTO_GENERATE_HONOR_CERTS'] = True
Use FEATURE setting to enable Honor mode auto-certs Committing Omar's suggestions Co-authored-by: Omar Al-Ithawi <i@omardo.com> Fix settings imports for Tahoe certs signals changes for Honor auto-certs, related tests. Add related default FEATURE setting in appsembler.settings
bryanlandia
force-pushed
the
bryan/allow-auto-generated-certs-for-honor
branch
from
December 23, 2020 19:04
f819437 to
7db75ba
Compare
Author
|
Updated with your suggestions @OmarIthawi and related fixes, then squashed. |
OmarIthawi
approved these changes
Dec 24, 2020
|
Looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even as of Koa, auto-generation of certs is not allowed for Audit or Honor. It is allowed for Verified, Credit, Professional, and No ID Professional. https://github.com/edx/edx-platform/blob/151bd136667d27bf85256e382ed5b5ea0144e00f/lms/djangoapps/certificates/signals.py#L145
None of the allowed modes work for Tahoe because:
So, we should just allow auto-certs for Honor. This PR does that.