Fixed bug in import_course_on_site_creation call - #556
Merged
Conversation
OmarIthawi
force-pushed
the
omar/course-async
branch
from
April 3, 2020 14:04
4e1a820 to
4850659
Compare
Now using serializable kwargs so tasks can run
OmarIthawi
force-pushed
the
omar/course-async
branch
from
April 3, 2020 14:06
4850659 to
6c3b190
Compare
Author
|
@melvinsoft I'm done with this. Please feel free to merge and deploy if the tests passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now using serializable kwargs so tasks can run for real 😅.
We don't have a test for the actual call yet in the
Registrationclass so I've refactored the call into a helper function so we keep the minimize the uncovered code. Not clean, but effective in my opinion.https://github.com/appsembler/edx-platform/blob/48506597a3053a865484a05582a017443b8c0c13/openedx/core/djangoapps/appsembler/sites/serializers.py#L139-141