Code review changes and tests for course import on site creation - #553
Merged
OmarIthawi merged 1 commit intoApr 1, 2020
Merged
Conversation
OmarIthawi
force-pushed
the
maxi/course-import-on-site-creation
branch
from
March 27, 2020 10:11
616e988 to
c36f9ab
Compare
OmarIthawi
changed the base branch from
maxi/course-import-on-site-creation
to
appsembler/tahoe/develop
March 27, 2020 10:22
OmarIthawi
changed the title
OmarIthawi
force-pushed
the
omar/maxi/course-import-on-site-creation
branch
3 times, most recently
from
March 30, 2020 08:33
f0b8309 to
71cd037
Compare
OmarIthawi
changed the title
OmarIthawi
force-pushed
the
omar/maxi/course-import-on-site-creation
branch
3 times, most recently
from
March 30, 2020 08:47
2b8d86a to
6509bdf
Compare
|
@OmarIthawi Thanks for writing this up, we have some problems with the test that are failing, I took a quick look and it's failing with some requirements we added/changes recently, looks like a cache issue. How can you clear cache in TravisCI? |
OmarIthawi
force-pushed
the
omar/maxi/course-import-on-site-creation
branch
from
March 31, 2020 07:30
74f6a00 to
97c9e7f
Compare
Author
|
@melvinsoft I've fixed the tests with a couple of Please take a look and let me know what do you think of the refactoring. |
melvinsoft
approved these changes
Mar 31, 2020
melvinsoft
left a comment
melvinsoft
left a comment
There was a problem hiding this comment.
@OmarIthawi Thanks for refactoring the code, it looks much better.
Author
|
Thanks @melvinsoft! I'm going to deploy now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I did an extensive review for #546 and this PR contains my suggestions and the test case I wrote.
List of Changes
source_dirsto have an array of directories. I think Course import on site creation #546 is brokenuuidin favor ofNamedTemporaryFiletahoe-first-course@v0.0.1release (3 Kilobytes course).TODO