Disable mongo debug pannel on django debug toolbar - #545
Merged
melvinsoft merged 2 commits intoMar 19, 2020
Conversation
OmarIthawi
approved these changes
Mar 19, 2020
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
Working on the course import feature, now we need to the course import function from the LMS, and it started to break.
Thanks for the fix @melvinsoft. I don't think this is a good idea to do course import from within the LMS. It should be possible to run CMS Celery tasks from within the LMS. Open edX LMS is not supposed to do any writes to MongoDB. Even if it works it's prune to errors.
thraxil
approved these changes
Mar 19, 2020
Co-Authored-By: Omar Al-Ithawi <i@omardo.com>
Author
|
@thraxil @OmarIthawi Thanks for your review! @OmarIthawi Let's discuss the course import approach in the other PR, I still believe is the best way to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This panel is already disabled in the CMS because it breaks every mongo query, but it still enabled in the LMS, since the LMS doesn't need to query mongo.
Working on the course import feature, now we need to the course import function from the LMS, and it started to break.