Move access control backends into courseware - #543
Merged
Conversation
Because it depends on AccessResponse class
OmarIthawi
force-pushed
the
omar/move-acb-courseware
branch
from
March 16, 2020 13:07
e49d853 to
a59c348
Compare
thraxil
approved these changes
Mar 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moving Access Control Backends to the
coursewareDjango app because it depends onAccessResponseclass. Basically I made a mistake in not checkinghas_accessproperly and this PR fixes the issue. Otherwise, Course Access Groups will throw an exception.Why
Access Control Backends were designed with the assumption that
courseware.access.has_accessreturns a simpleTrueorFalse. I turns out it returns a magical object of typeAccessResponse, which can be cast tobool.Reference
edx-platform/lms/djangoapps/courseware/access_response.py
Lines 10 to 11 in c338b75
and
edx-platform/lms/djangoapps/courseware/access_response.py
Lines 32 to 44 in c338b75