Fix COURSE_GRADE_NOW_PASSED signal for Ginkgo - #538
Merged
bryanlandia merged 1 commit intoMar 11, 2020
Merged
Conversation
bryanlandia
force-pushed
the
appsembler/ginkgo/fix-course-passed-signal
branch
4 times, most recently
from
March 10, 2020 08:13
1a2d37e to
b24de91
Compare
(feature never worked in Ginkgo open releases)
bryanlandia
force-pushed
the
appsembler/ginkgo/fix-course-passed-signal
branch
from
March 11, 2020 01:50
b24de91 to
7634e3b
Compare
bryanlandia
changed the title
amirtds
approved these changes
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bugfix for Ginkgo which doesn't
need to be carried forward as logic is entirely reworked in Hawthorn+
note: Auto-certificates on passing grade requires enabling
PersistentCourseGrades via Django Admin for all coursesThis does introduce a slight performance overhead when calculating grades but it would require too much rework for the budget we have to avoid it, and this is resolved with Hawthorn's refactor of grading, anyhow. TBD though whether this feature works out of the box in Hawthorn. It looks like it should but it's not tested.