Upgrade to Mongo 3.6

[melvinsoft]

No description provided.

[OmarIthawi]

@melvinsoft That's amazing! Please add the tests to tox.ini:

common/lib/xmodule/xmodule/modulestore/tests/test_mongo_call_count.py
common/lib/xmodule/xmodule/modulestore/tests/test_split_mongo_mongo_connection.py
lms/djangoapps/verify_student/management/commands/tests/test_send_verification_expiry_email.py
lms/djangoapps/verify_student/tests/test_services.py

[thraxil]

Exciting. The commit notes say "This version of pymongo supports MongoDB 2.x all the way up to 4.2". We might even be able to move to 4.x in the foreseeable future.

[melvinsoft]

@OmarIthawi Thanks for the review, I added the test you requested but then I deleted one: lms/djangoapps/verify_student/management/commands/tests/test_send_verification_expiry_email.py since is testing new code we don't have yet, and more intended for python 3 rather than 2.

But tests are still failing, new fails are related to Access Control Backend:

py27-lms run-test: commands[3] | lms/lib/tests/test_access_control_backends.py openedx/core/djangoapps/appsembler openedx/core/djangoapps/site_configuration/tests/test_tahoe_changes.py openedx/core/djangoapps/user_api/accounts/tests/test_utils.py::CompletionUtilsTestCase
ERROR: InvocationError for command could not find executable lms/lib/tests/test_access_control_backends.py

I invested about three hours until I reached this point, can you please take a quick look? If not we should move forward without the new tests, and do it as a follow up work.

What do you think?

[OmarIthawi]

Thanks @melvinsoft! tox.ini now has syntax errors and I've fixed them.

TL; DR;

In general I think in tests for the edx-platform we probably want to take things slowly and steer clear from rabbit holes. But now the tests are fixed, we don't need to worry about it.

Even in the best case scenario, we don't want all tests to run, maybe 99% at max, this is to make it possible for us to deviate from Open edX in a healthy way until we make plugins or APIs.

Thank you again!

[OmarIthawi]

Let's get those trailing slashes to avoid breaking the tests

[OmarIthawi]

Thanks @melvinsoft! I've fixed the tox.ini and cleaned the branch (I also did a push --force). I'll merge once tests passes.

Note that this might break devstack (right?) and we'd might to upgrade MongoDB there as far as I know.

[melvinsoft]

@OmarIthawi Thanks for all the help here. I'm merging this now.

[melvinsoft]

@OmarIthawi Why do you think is gonna break devstack? because the authSource and replicaSet parameters in the connection?