Added and fixed entrance exam tests + re-order tox entries - #497
Merged
Conversation
OmarIthawi
force-pushed
the
omar/entrance-exam
branch
from
December 4, 2019 08:32
766e08a to
40f0e5b
Compare
OmarIthawi
force-pushed
the
omar/entrance-exam
branch
2 times, most recently
from
December 4, 2019 11:44
9a8b9ad to
384b50d
Compare
OmarIthawi
changed the title
OmarIthawi
force-pushed
the
omar/entrance-exam
branch
from
December 4, 2019 11:47
384b50d to
16c18f8
Compare
Author
|
This should pave the way for adding tests to #494 |
thraxil
approved these changes
Dec 4, 2019
| sql_queries=sql_queries) | ||
| # Appsembler: Hack, make tests passes. | ||
| # Somehow we have one less query. | ||
| sql_queries=sql_queries - 1) |
There was a problem hiding this comment.
Weird. I don't really like their approach of passing/failing a test based on the number of SQL queries anyway. That seems like a hack approach to preventing performance regressions, so I'm ok doing what we need to to bypass it.
Author
There was a problem hiding this comment.
@thraxil that's right, it's a maintenance headache. Unfortunately this is a very common pattern in Open edX tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commonenvironment