Update French (Canada) and Japanese translations

[OmarIthawi]

I've done the following:

• Marked all the French Canadian hawthorn/-js as reviewed.
• Same for Japanese (more info on the Open edX Slack).
• Updated Japanese and Canadian French via $ paver i18n_robot_pull
• Committed and pushed to GitHub.

This is mainly to resolve a couple of PSAC reported issues.

[johnbaldwin]

@OmarIthawi singular 'flag'?

[johnbaldwin]

@OmarIthawi I skimmed over one of the files and see what look like three cases:

"there is currently {numVotes} vote": [
	      "il y a actuellement {numVotes} vote", 
	      "il y a actuellement {numVotes} votes"
	    ], 

For the english expression, is that always singular?

[OmarIthawi]

Thanks @johnbaldwin.

@OmarIthawi I skimmed over one of the files and see what look like three cases:

"there is currently {numVotes} vote": [
	      "il y a actuellement {numVotes} vote", 
	      "il y a actuellement {numVotes} votes"
	    ], 

For the english expression, is that always singular?

So, not really. The file has been generated by a script.

Looking at the corresponding JavaScript-based functions:

edx-platform/cms/static/js/i18n/ar/djangojs.js

Lines 8 to 15 in f1cc004

	django.pluralidx = function(n) {
	var v=n==0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 && n%100<=10 ? 3 : n%100>=11 && n%100<=99 ? 4 : 5;
	if (typeof(v) == 'boolean') {
	return v ? 1 : 0;
	} else {
	return v;
	}
	};

edx-platform/cms/static/js/i18n/ar/djangojs.js

Lines 1947 to 1954 in f1cc004

	django.ngettext = function(singular, plural, count) {
	var value = django.catalog[singular];
	if (typeof(value) == 'undefined') {
	return (count == 1) ? singular : plural;
	} else {
	return value[django.pluralidx(count)];
	}
	};

The English plural form exists in the source:

edx-platform/common/static/common/js/discussion/views/discussion_content_view.js

Lines 279 to 281 in 5bc6b31

	votesCountMsg = ngettext(
	'there is currently {numVotes} vote', 'there are currently {numVotes} votes', numVotes
	);

So it looks like, unlike the po files which preserves the original English plural form, the JavaScript file ignores it. Mostly a space-saving measure since the English plural form is useless in the Arabic context.

That's what I think, please let me know what do you think?

[johnbaldwin]

@OmarIthawi Honestly, I would need to dig into the translations code to understand how it handles pluralization. I'll accept your explanation on English -> Arabic pluralization

[OmarIthawi]

Thanks @johnbaldwin, it's literally just the two function above ☝️

Yes, there's a lot of more context and tooling around this to get to those functions, but that's what the user needs on their browsers to be able to see Arabic (and other languages) for the JavaScript strings.