Tests and fixes for the exclusive SSO logistration view

lms/djangoapps/student_account/test/test_exclusive_sso_logsitration.py

@@ -0,0 +1,109 @@
+# -*- coding: utf-8 -*-
+""" Tests for student account views. """
+
+import mock
+import ddt
+from django.conf import settings
+from django.core.urlresolvers import reverse
+from django.contrib.auth import get_user_model
+from django.test.utils import override_settings
+from nose.plugins.attrib import attr
+from course_modes.models import CourseMode
+from third_party_auth.tests.testutil import simulate_running_pipeline, ThirdPartyAuthTestMixin
+from util.testing import UrlResetMixin
+from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase
+
+
+LOGGER_NAME = 'audit'
+User = get_user_model()  # pylint:disable=invalid-name
+
+
+@attr(shard=3)
+@ddt.ddt
+@override_settings(
+    # Sane Appsembler default settings
+    APPSEMBLER_FEATURES={},
+    CUSTOM_SSO_FIELDS_SYNC={},
+    CUSTOM_LOGOUT_REDIRECT_URL='https://sso.auth/logout',
+    EXCLUSIVE_SSO_LOGISTRATION_URL_MAP={},
+)
+class StudentAccountLoginAndRegistrationTest(ThirdPartyAuthTestMixin, UrlResetMixin, ModuleStoreTestCase):
+    """ Tests for the student account views that update the user's account information. """
+
+    USERNAME = "bob"
+    EMAIL = "bob@example.com"
+    PASSWORD = "password"
+
+    URLCONF_MODULES = ['openedx.core.djangoapps.embargo']
+
+    @mock.patch.dict(settings.FEATURES, {'EMBARGO': True})
+    def setUp(self):
+        super(StudentAccountLoginAndRegistrationTest, self).setUp()
+
+        # For these tests, one third party auth provider is enabled
+        self.configure_google_provider(enabled=True, visible=True)
+
+    @ddt.data(
+        ("signin_user", "login", "https://sso.auth/login",),
+        ("register_user", "register", "https://sso.auth/register"),
+    )
+    @ddt.unpack
+    def test_exclusive_sso_logistration(self, url_name, view_type, exclusive_sso_url):
+        params = [
+            ('course_id', 'course-v1:Org+Course+Run'),
+            ('enrollment_action', 'enroll'),
+            ('course_mode', CourseMode.DEFAULT_MODE_SLUG),
+            ('email_opt_in', 'true'),
+            ('next', '/custom/final/destination'),
+        ]
+
+        sso_settings = {
+            'APPSEMBLER_FEATURES': {
+                'ENABLE_EXCLUSIVE_SSO_LOGISTRATION': True,
+            },
+            'EXCLUSIVE_SSO_LOGISTRATION_URL_MAP': {
+                view_type: exclusive_sso_url,
+            },
+        }
+
+        # A sanity check
+        self.assertRedirects(
+            response=self.client.get(reverse('dashboard')),
+            expected_url='{signin}?next=/dashboard'.format(signin=reverse('signin_user')),
+            msg_prefix='The user should NOT be logged in',
+            fetch_redirect_response=False,
+        )
+
+        self.assertContains(
+            response=self.client.get(reverse(url_name), params),
+            text='form',
+            status_code=200,
+            msg_prefix='Should NOT redirect: no running auth pipeline and feature is disabled.',
+        )
+
+        with override_settings(**sso_settings):
+            self.assertRedirects(
+                response=self.client.get(reverse(url_name), params),
+                expected_url=exclusive_sso_url,
+                msg_prefix='Should redirect: pipeline is NOT running AND the feature is enabled.',
+                fetch_redirect_response=False,
+            )
+
+        pipeline_target = "student_account.views.third_party_auth.pipeline"
+        with simulate_running_pipeline(pipeline_target, "google-oauth2"):
+            self.assertContains(
+                response=self.client.get(reverse(url_name), params),
+                text='form',
+                status_code=200,
+                msg_prefix='Should NOT redirect: pipeline is running anyway AND the feature is disabled',
+            )
+
+        with override_settings(**sso_settings):
+            with simulate_running_pipeline(pipeline_target, "google-oauth2"):
+                self.assertContains(
+                    response=self.client.get(reverse(url_name), params),
+                    text='form',
+                    status_code=200,
+                    # Giving a chance for the `autoSubmitRegForm` to work, a redirect would prevent it.
+                    msg_prefix='Should NOT redirect: Pipeline is running, regardless of the feature',
+                )

lms/djangoapps/student_account/views.py

@@ -115,16 +115,15 @@ def login_and_registration_form(request, initial_mode="login"):
     if ext_auth_response is not None:
         return ext_auth_response
 
-    third_party_auth = _third_party_auth_context(request, redirect_to)
-    if not third_party_auth['currentProvider']:
+    tpa_context = _third_party_auth_context(request, redirect_to)
+    if not tpa_context['currentProvider']:
         if settings.APPSEMBLER_FEATURES.get('ENABLE_EXCLUSIVE_SSO_LOGISTRATION'):
             urls_dict = configuration_helpers.get_value(
                 'EXCLUSIVE_SSO_LOGISTRATION_URL_MAP',
                 settings.EXCLUSIVE_SSO_LOGISTRATION_URL_MAP)
 
             if initial_mode == 'register':
-                if 'register' in urls_dict:
-                    return redirect(urls_dict['register'])
+                return redirect(urls_dict['register'])
             else:
                 return redirect(urls_dict['login'])
 
@@ -133,7 +132,7 @@ def login_and_registration_form(request, initial_mode="login"):
         'data': {
             'login_redirect_url': redirect_to,
             'initial_mode': initial_mode,
-            'third_party_auth': third_party_auth,
+            'third_party_auth': tpa_context,
             'third_party_auth_hint': third_party_auth_hint or '',
             'platform_name': configuration_helpers.get_value('PLATFORM_NAME', settings.PLATFORM_NAME),
             'support_link': configuration_helpers.get_value('SUPPORT_SITE_LINK', settings.SUPPORT_SITE_LINK),