Skip to content

Add the option of use only SSO login and register - #192

Merged
melvinsoft merged 2 commits into
appsembler/eucalyptus/developfrom
maxi/sso-exclusive-logistration
Dec 20, 2017
Merged

Add the option of use only SSO login and register#192
melvinsoft merged 2 commits into
appsembler/eucalyptus/developfrom
maxi/sso-exclusive-logistration

Conversation

@melvinsoft

@melvinsoft melvinsoft commented Dec 14, 2017

Copy link
Copy Markdown

The PR introduces the ability of redirect the login and register page AKA logistration to an SSO Identity Provider, this is more efficient than using Nginx rules as we currently do.

This is a temporary patch, since we already have a ProdPad idea to implements this upstream first and then start using it.

How to test it:

  1. Checkout this branch.
  2. Add a new feature flag under APPSEMBLER_FEATURES:
"ENABLE_EXCLUSIVE_SSO_LOGISTRATION": true
  1. Add a new Env variable with a url map:
"EXCLUSIVE_SSO_LOGISTRATION_URL_MAP": {
        "register": "http://appsembler.com",
        "login": "http://appsembler.com"
    },

@melvinsoft

Copy link
Copy Markdown
Author

@OmarIthawi OmarIthawi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Maxi! Thanks!

Comment thread lms/envs/aws.py Outdated

AFFILIATE_COOKIE_NAME = ENV_TOKENS.get('AFFILIATE_COOKIE_NAME', AFFILIATE_COOKIE_NAME)

EXCLUSIVE_SSO_LOGISTRATION_URL_MAP = ENV_TOKENS.get('EXCLUSIVE_SSO_LOGISTRATION_URL_MAP', {}) No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melvinsoft you've used aws.py, but devstack_appsembler.py. Care to unify?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OmarIthawi Thanks, change addressed.

@OmarIthawi

Copy link
Copy Markdown

Thanks @melvinsoft! Looking forward to get this merged!

@melvinsoft
melvinsoft merged commit af06a9b into appsembler/eucalyptus/develop Dec 20, 2017
@melvinsoft
melvinsoft deleted the maxi/sso-exclusive-logistration branch December 20, 2017 13:02
OmarIthawi added a commit that referenced this pull request Jan 23, 2018
This is a Ficus cherry-pick for Maxi's #192
OmarIthawi added a commit that referenced this pull request Aug 2, 2018
This is a Ginkgo cherry-pick for:

 - Eucalyptus: Maxi's #192
 - Ficus: Omar's #200
OmarIthawi pushed a commit that referenced this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants